-
-
Notifications
You must be signed in to change notification settings - Fork 78.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Button shadow is hardcoded #24242
Comments
We should have a variable for the '3px' |
Hi @Kopyov, you are right it is hardcoded. Thanks for bringing it up. For focus state you would always want a visual indication of the focus ring to make your implementations accessible. And since the mixin is using the The active state shadow might look deceiving since it's using both focus and active shadows, but that should be expected behaviour, right? An active btn should be focus. @myorangeca A variable for the size of the focus ring (the |
I am not sure why it would be confusing but maybe I am not seeing the big picture. To my limited knowledge, there should be a variable for all instances whenever it is needed. I personally like the '3px' to be '2px' like on alpha.6, but I don't want to edit the bootstrap core files in-order to do this. This goes for alert colors as well. I raised an issue earlier but to no avail... #23894 |
Thanks for explaining the logic, @andresgalante |
Hi @myorangeca you are right, a btn focus size variable can be a good solution to this issue. |
I'm using beta2 and I'd like to disable the box-shadow for active buttons (not focus). $btn-active-box-shadow: none; But this has no effect |
|
It worked @manavm1990 Thanks |
$input-focus-width: 0; This is really worked to remove shadow or outline from input element |
Class Now bootstrap 4.1 introduced |
I believe a lot of people like me want to remove the ugly shadow outside the button. |
We have 3 variables for button shadow:
2 issues here:
Same for $btn-focus-box-shadow variable.
2. Seems like i can't remove 3px shadow in focus/active states as it's hardcoded in button mixin:
Please make it optional.
The text was updated successfully, but these errors were encountered: