Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libsass miscompiles breadcrumb content #919

Closed
cvrebert opened this issue Jun 17, 2015 · 10 comments
Closed

libsass miscompiles breadcrumb content #919

cvrebert opened this issue Jun 17, 2015 · 10 comments
Labels
Milestone

Comments

@cvrebert
Copy link
Collaborator

Under the environment:

sassc: 3.2.1
libsass: 3.2.4
sass2scss: 1.0.3

the SCSS in question:

content: "#{$breadcrumb-separator}\00a0";

is getting compiled to:

content: "/\\00a0";

which is incorrect.
By comparison, Ruby Sass compiles this code to:

content: "/ ";

which is correct (albeit not ASCII).

This is due to a bug in libsass: sass/libsass#1115

The questions are (a) should bootstrap-sass try to workaround this? (b) if yes, how? (c) if yes, since this only affects libsass, do we make the change in bootstrap-sass, or in upstream Bootstrap?
CC: @twbs/sass

@trshafer
Copy link

Thanks for looking into this. I am experiencing this issue.

@glebm
Copy link
Member

glebm commented Jun 30, 2015

(b) One work around is to define \a00a0 as a variable. Under libsass 3.2.5 this compiles to:

$ echo 'a { $a: "/"; $b: "\00a0"; x: "#{$a}#{$b}" }' | node-sass
@charset "UTF-8";
a {
  x: ""; }

(a) Since the workaround is easy, I'll add it in for the time being.
(c) Not sure whether this should be implemented upstream or here? Any use cases for characters other than  ?


Note that the UTF-8 encoding causes #803 for IE 10/11 when other non-UTF8 CSS files are concatenated incorrectly, though that is something we decided not to deal with.

@cvrebert
Copy link
Collaborator Author

cvrebert commented Jul 1, 2015

As this issue is completely libsass-specific, it seems logical to keep it downstream, IMO.

@glebm glebm added this to the v3.3.6 milestone Jul 1, 2015
@glebm glebm closed this as completed in 47819e8 Jul 1, 2015
@glebm
Copy link
Member

glebm commented Jul 1, 2015

This has been fixed on master and 3.3-stable and will be in the next release.

@klierik
Copy link

klierik commented Jul 15, 2015

Can you please update composer module https://packagist.org/packages/twbs/bootstrap-sass to latest version with this fix. now it is only:

$ composer show
installed:
  ...
  twbs/bootstrap-sass                          v3.3.5             bootstrap-sass is a Sass-powered version of Bootstrap, ready to drop right into your Sass powered applications.

@cvrebert
Copy link
Collaborator Author

@klierik We have yet to ship a new release version since the fix was merged. Please be patient. The Composer package isn't any more outdated than our other packages. Thanks.

slayerfat added a commit to slayerfat/orbiagro.com.ve that referenced this issue Jul 20, 2015
cdosborn added a commit to cyverse/troposphere that referenced this issue Aug 12, 2015
bootstrap-sass is pointing to github while we are awaiting a fix to a
sass bug (twbs/bootstrap-sass#919)
@realityking
Copy link

@cvrebert Looking at the 3.3.6 milestone for Bootstrap it seems like it won't be ready soon. Any chance you could cut release with this fix before the upstream release?

@realityking
Copy link

@glebm @cvrebert Not trying to be a pain in the neck, but it's been 3 months since this has been fixed but there hasn't been a bootstrap release. Could we get bootstrap-sass release?

@kylekz
Copy link

kylekz commented Oct 13, 2015

@realityking Temporary workaround:

.breadcrumb > li + li:before {
    content: "/\00a0";
    color: $breadcrumb-color;
}

@furey
Copy link

furey commented Nov 18, 2015

@xKairu Lifesaver. Thank you.

ElMassimo pushed a commit to SolarCS/bootstrap-sass that referenced this issue Apr 11, 2017
maltehuebner added a commit to criticalmass-one/criticalmass-in that referenced this issue Jun 1, 2017
alanorth added a commit to alanorth/DSpace that referenced this issue May 10, 2022
This is due to using node-sass instead of Ruby compass. The header
trail shows  instead of /.

See: twbs/bootstrap-sass#919
alanorth added a commit to alanorth/DSpace that referenced this issue May 31, 2022
This is due to using node-sass instead of Ruby compass. The header
trail shows  instead of /.

See: twbs/bootstrap-sass#919
dspeed2 pushed a commit to UoE-DataShare/DSpace that referenced this issue Jun 6, 2022
This is due to using node-sass instead of Ruby compass. The header
trail shows  instead of /.

See: twbs/bootstrap-sass#919
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

7 participants