Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extra Mode branch #88

Open
Abdur-rahmaanJ opened this issue Dec 13, 2022 · 1 comment
Open

Extra Mode branch #88

Abdur-rahmaanJ opened this issue Dec 13, 2022 · 1 comment

Comments

@Abdur-rahmaanJ
Copy link
Contributor

LibSQL would like to remain compatible as long as possible with sqlite. However, PRs such as #87 tend to break compatibility. The feature it offers is great though. This is why i suggest having an "extra" branch where releases containing incompatible changes are merged so that people get to enjoy a power version of sqlite.
@psarna
Copy link
Collaborator

psarna commented Dec 13, 2022

I think that it's fine to diverge in a way that #87 does it -- sqlite_module has a version number, so the existing code remains compatible, and only upgrades when the authors want it. A second branch would be a good idea, but it also doubles the maintainership burden, so for now I'd rather stick to a single main branch, and keep it as compatible as possible, but not at all costs (e.g. #87 is definitely good enough to just go in).

@penberg opinions?

MarinPostma added a commit that referenced this issue Oct 17, 2023
@bors @MarinPostma
Merge #88
70062c5 
88: improve syntax error message r=penberg a=MarinPostma

improve the error message when a syntax error is encountered.

The parser is a bit sloppy when it comes to reporting the error locations, sometimes pointing farther than he should. I'll see if this is fixable later, or if this is a feature of the lemon parser 😄

the error message looks like:
```
>> echo '{"statements": ["selecct count(*) from test where x = 12"]}' | http post "127.0.0.1:8080"
{"error":"syntax error around L1:8: `selecct`"}
```


Co-authored-by: ad hoc <postma.marin@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@psarna @Abdur-rahmaanJ