Skip to content
This repository has been archived by the owner on May 17, 2023. It is now read-only.

Added missing parslet dependency to gemspec #6

Merged
merged 1 commit into from
Oct 31, 2011
Merged

Added missing parslet dependency to gemspec #6

merged 1 commit into from
Oct 31, 2011

Conversation

tindron
Copy link
Collaborator

@tindron tindron commented Oct 31, 2011

No description provided.

@turboladen
Copy link
Owner

parslet is a dependency of the sdp gem: https://github.com/turboladen/sdp/blob/master/sdp.gemspec, and I dont think it should be added here; that would mean maintaining the dep in 2 places. You can see there that the version spec is ~>1.1.0.

I think I recently ran into what Im guessing youre running in to, where youve got parslet ~>1.1.0 installed, as well as >=1.2.0, and requiring rtsp is complaining about the parslet dependencyis that right? If thats the case, Im not sure what the right fix is (as it seems to me the RubyGems wasnt finding the right version of the gem to require); as a (poor) workaround, I just uninstalled the parslet versions >= 1.2.0. Do you have a better suggestion?

On Oct 31, 2011, at 11:43 AM, tindron wrote:

You can merge this Pull Request by running:

git pull https://github.com/tindron/rtsp patch-1

Or you can view, comment on it, or merge it online at:

#6

-- Commit Summary --

  • Added missing parslet dependency to gemspec

-- File Changes --

M rtsp.gemspec (1)

-- Patch Links --

https://github.com/turboladen/rtsp/pull/6.patch
https://github.com/turboladen/rtsp/pull/6.diff

Reply to this email directly or view it on GitHub:
#6

@turboladen
Copy link
Owner

Never mind--you're right! I forgot about transport_parser!

turboladen added a commit that referenced this pull request Oct 31, 2011
Added missing parslet dependency to gemspec
@turboladen turboladen merged commit d1eb4a0 into turboladen:master Oct 31, 2011
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants