Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

About internationalization #9

Open
mitsugu opened this issue Feb 20, 2024 · 1 comment · May be fixed by #10
Open

About internationalization #9

mitsugu opened this issue Feb 20, 2024 · 1 comment · May be fixed by #10

Comments

@mitsugu
Copy link

mitsugu commented Feb 20, 2024

Hi.

I've internationalized your Java version of Carcassonne and added a Japanese locale in addition to the English one, but I wonder if it's needed?
It's not fully internationalized yet, and the internal error handling and exception handling are untouched, but can I send you a pull request?

I would appreciate it if you would consider it.

I compile my work list into a spreadsheet.
https://docs.google.com/spreadsheets/d/18gFQ-fRBKEtsUixTwGWbh5bhq8yKL0x7LH1ouW5mAXg/edit?usp=sharing

@mitsugu mitsugu linked a pull request Feb 21, 2024 that will close this issue
@tsaglam
Copy link
Owner

tsaglam commented Feb 22, 2024

I think it is a cool idea. Ideally, we would ensure proper internationalization that theoretically supports many languages.

@tsaglam tsaglam linked a pull request Feb 22, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants