Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: Are individual files for entity extracts needed? #6

Open
apoorvumang opened this issue Mar 20, 2021 · 1 comment
Open

Comments

@apoorvumang
Copy link

Hi, thanks for the dataset!

Unzipping extracts.zip for english took almost 30min on a RAID-6 HDD for me (since there are around 60k files). Wouldn't a single json be better, like entities.json? I have modified the code and create a PR (#5), it might be useful for people who want a quick install on a server with slow disk writes.

@tsafavi
Copy link
Owner

tsafavi commented Apr 16, 2021

Hey @apoorvumang, thanks for the good suggestion and apologies for my late response.

In your PR, can you also please update the quickstart section of the README to reflect that the user can choose between running the extract.sh script (individual files) or using the json file that you provide? Best to mention the tradeoffs between the two approaches -- disk write speed, memory usage, etc.

Also, ideally we would have entity_extracts.json for all languages, not just English. But I can handle that if it takes you too long to run the extraction for other languages.

Tara

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants