release pipeline related fixes #1435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:L
sfc-gh-pmardziel
changed the title
dosubot
bot
added
size:XXL
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
sfc-gh-jreini
approved these changes
Sep 3, 2024
sfc-gh-chu
pushed a commit
that referenced
this pull request
Sep 25, 2024
* upgrade llama_index reqs and testing of old notebooks * disable part of deprecation tests * nit * fixing golden serial and dummy * fixing more tests * fix app_id -> app_name * fix more test_tru_session tests * fixing more * put placeholder data back for async results * working on async issues * PR comment fixes * nits * docs update * another note * nit to docs * disable prints
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes a few things that got broken in the execution of old notebooks.
Fixes a few tests that were run as part of the release pipeline.
Removed
database_filearg as it was a deprecation warning for a long time.Added more optional deps to the
tests-optionalgroup inpyproject.tomlas they are required for the release tests.Fix to
App.select_contextto be more informative in case optional modules are not installed.Updated versions of various llama_index dependencies in
pyproject.tomlas I was finding bugs in older versions.Small fix to
TruChain.main_inputfor an edge/new case.Typo fix in
n_cortext_guardrails_tokens.Added
Record.__str__to print fewer, and more useful things than default__str__from pydantic: the calls and their paths.Refactored
JSONTestCaseas I might need to extend other things thanunittest.TestCasefor async tests.Temporarily disabled
deprecation.class_movedmechanism due to interference with serialization. Also disabled the related unit test.TODO (will make a new PR for this) fix async handling. Started work on this but it is incomplete.
Other details good to know for developers
Please include any other details of this change useful for TruLens developers.
Type of change
not work as expected)