remove deprecated legacy caching #1233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:XS
|
Anyone check whether this has any impact on the UI (or maybe what the cache was doing in the first place?) |
Tested on the 5k records x 6 feedback set, with minimal change from baseline:
|
sfc-gh-chu
approved these changes
Jun 21, 2024
@sfc-gh-pmardziel doesn't seem to make an impact on the dashboard since we're not caching anything atm afaik. Not sure why it was there for to begin with |
Merged
sfc-gh-dhuang
pushed a commit
that referenced
this pull request
Jun 28, 2024
* remove deprecated legacy caching * fmt
sfc-gh-jreini
added a commit
that referenced
this pull request
Jul 1, 2024
* remove deprecated legacy caching * fmt
sfc-gh-dhuang
pushed a commit
that referenced
this pull request
Jul 1, 2024
* remove deprecated legacy caching * fmt
sfc-gh-chu
pushed a commit
that referenced
this pull request
Sep 25, 2024
* remove deprecated legacy caching * fmt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Other details that are good to know but need not be announced: