Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support for langchain >=0.2.x retrievers #1187

Merged
merged 3 commits into from
Jun 9, 2024

Conversation

nicoloboschi
Copy link
Contributor

Starting from langchain 0.1.46 the BaseRetriever#_get_relevant_documents has been deprecated and replaced by invoke.
Retrievers that have done the full migration (and they don't implement _get_relevant_documents anymore) makes the TruChain fails consistently.

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. dependencies Pull requests that update a dependency file labels Jun 7, 2024
@sfc-gh-jreini sfc-gh-jreini requested a review from a team June 7, 2024 17:27
Copy link
Contributor

@sfc-gh-jreini sfc-gh-jreini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jun 7, 2024
@sfc-gh-jreini sfc-gh-jreini merged commit aed8b27 into truera:main Jun 9, 2024
3 checks passed
@sfc-gh-jreini sfc-gh-jreini linked an issue Jun 9, 2024 that may be closed by this pull request
@nicoloboschi nicoloboschi deleted the supportlangchain02 branch June 10, 2024 08:04
sfc-gh-dhuang pushed a commit that referenced this pull request Jun 28, 2024
* feat: support for langchain >=0.2.x retrievers

* feat: support for langchain >=0.2.x retrievers

---------

Co-authored-by: Josh Reini <josh.reini@snowflake.com>
sfc-gh-dhuang pushed a commit that referenced this pull request Jul 1, 2024
* feat: support for langchain >=0.2.x retrievers

* feat: support for langchain >=0.2.x retrievers

---------

Co-authored-by: Josh Reini <josh.reini@snowflake.com>
sfc-gh-chu pushed a commit that referenced this pull request Sep 25, 2024
* feat: support for langchain >=0.2.x retrievers

* feat: support for langchain >=0.2.x retrievers

---------

Co-authored-by: Josh Reini <josh.reini@snowflake.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Langchain Quickstart notebook does not work
2 participants