Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show OSS models (and tracking) in LiteLLM application #1109

Merged
merged 6 commits into from
Apr 29, 2024

Conversation

joshreini1
Copy link
Contributor

Items to add to release announcement:

  • Show TruLens tracking of OSS models in core LLM app

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@joshreini1 joshreini1 marked this pull request as ready for review April 29, 2024 19:28
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Apr 29, 2024
Copy link
Contributor

@daniel-huang-1230 daniel-huang-1230 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me!

Could we also add a link to https://litellm.vercel.app/docs/completion/token_usage#5-completion_cost perhaps on the top in the markdown description so that users can refer to the model cost setup and configurability within LiteLLM and down the road see them in TruLens dashboard?

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Apr 29, 2024
@dosubot dosubot bot added size:XXL This PR changes 1000+ lines, ignoring generated files. size:M This PR changes 30-99 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. size:XXL This PR changes 1000+ lines, ignoring generated files. labels Apr 29, 2024
@truera truera deleted a comment from gitguardian bot Apr 29, 2024
Copy link

gitguardian bot commented Apr 29, 2024

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them.
Once a secret has been leaked into a git repository, you should consider it compromised, even if it was deleted immediately.
Find here more information about risks.


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@dosubot dosubot bot added size:XXL This PR changes 1000+ lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Apr 29, 2024
@joshreini1
Copy link
Contributor Author

Looks great to me!

Could we also add a link to https://litellm.vercel.app/docs/completion/token_usage#5-completion_cost perhaps on the top in the markdown description so that users can refer to the model cost setup and configurability within LiteLLM and down the road see them in TruLens dashboard?

We already use litellm.completion_cost in the background and get the cost tracking, part of what I'm trying to show in this change. Adding the leaderboard output to show this. Would it still be useful to link to the litellm cost references?

Here's the line reference:

setattr(self.cost, "cost", completion_cost(response))

@daniel-huang-1230
Copy link
Contributor

Looks great to me!
Could we also add a link to https://litellm.vercel.app/docs/completion/token_usage#5-completion_cost perhaps on the top in the markdown description so that users can refer to the model cost setup and configurability within LiteLLM and down the road see them in TruLens dashboard?

We already use litellm.completion_cost in the background and get the cost tracking, part of what I'm trying to show in this change. Adding the leaderboard output to show this. Would it still be useful to link to the litellm cost references?

Here's the line reference:

setattr(self.cost, "cost", completion_cost(response))

Cool! yes the added cell output looks good to me and should be plenty clear for the user hopefully.
I'm aware the usage of completion_cost and also the motivation for this change 👍 (Originally was thinking about adding the link just because I've encountered user recently on Github asking about cost-tracking with LiteLLM)

@joshreini1
Copy link
Contributor Author

Looks great to me!
Could we also add a link to https://litellm.vercel.app/docs/completion/token_usage#5-completion_cost perhaps on the top in the markdown description so that users can refer to the model cost setup and configurability within LiteLLM and down the road see them in TruLens dashboard?

We already use litellm.completion_cost in the background and get the cost tracking, part of what I'm trying to show in this change. Adding the leaderboard output to show this. Would it still be useful to link to the litellm cost references?
Here's the line reference:

setattr(self.cost, "cost", completion_cost(response))

Cool! yes the added cell output looks good to me and should be plenty clear for the user hopefully. I'm aware the usage of completion_cost and also the motivation for this change 👍 (Originally was thinking about adding the link just because I've encountered user recently on Github asking about cost-tracking with LiteLLM)

Ahh - I see the gh issue where they're looking to track a model not in this list. Added the link to this list in the header to make this clear!

@joshreini1 joshreini1 merged commit 96d6765 into main Apr 29, 2024
9 checks passed
sfc-gh-dhuang pushed a commit that referenced this pull request Jun 28, 2024
* oss models in app

* import change

* fix dims issue, pass embeddings manually

* keep some output

* remove settings print

* link model list for cost tracking
sfc-gh-chu pushed a commit that referenced this pull request Sep 25, 2024
* oss models in app

* import change

* fix dims issue, pass embeddings manually

* keep some output

* remove settings print

* link model list for cost tracking
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:XXL This PR changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants