better singleton already made warnings #1088
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Other details that are good to know but need not be announced:
Will print out
The first part is the existing warning but the second points out the source code line that caused the singleton to be created to begin with. In this case, the call to Groundedness created a default openai client hence the second one's configuration is ignored. Note the weird source code file name is because this is in a jupyter notebook running on vscode.
Added this warning to
OpenAIEndpoint
,LiteLLMEndpoint
, andTru
.