Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix test-tru #1070

Merged
merged 8 commits into from
Apr 17, 2024
Merged

fix test-tru #1070

merged 8 commits into from
Apr 17, 2024

Conversation

piotrm0
Copy link
Contributor

@piotrm0 piotrm0 commented Apr 15, 2024

Other details that are good to know but need not be announced:

  • Fixing import issues in test_tru.py . There is another issue in use of AppDefinition which is not yet fixed.
  • Adjusted some docs.

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Apr 15, 2024
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Apr 15, 2024
@piotrm0 piotrm0 requested a review from arn-tru April 15, 2024 17:24
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Apr 17, 2024
@piotrm0 piotrm0 merged commit ba4cae3 into main Apr 17, 2024
3 of 9 checks passed
sfc-gh-dhuang pushed a commit that referenced this pull request Jun 28, 2024
* fix test-tru

* order

* try again

* typo

* order

* fix some docs

---------

Co-authored-by: Aaron <163380706+arn-tru@users.noreply.github.com>
sfc-gh-chu pushed a commit that referenced this pull request Sep 25, 2024
* fix test-tru

* order

* try again

* typo

* order

* fix some docs

---------

Co-authored-by: Aaron <163380706+arn-tru@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants