Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Faster jit #3648

Merged
merged 12 commits into from
Apr 13, 2024
Merged

Faster jit #3648

merged 12 commits into from
Apr 13, 2024

Conversation

apgoucher
Copy link
Collaborator

@apgoucher apgoucher commented Apr 13, 2024

This is a further 2.7x speedup (from 49us to 18us) of kernel launch overhead compared with the previous PR, with help from cProfile to find the hotspots.

Also fixes an old compiler bug where the None-ness of arguments didn't enter into the cache key, leading to scary bugs.

… already serialise their values to compute the key
Copy link
Collaborator

@ThomasRaoux ThomasRaoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@apgoucher apgoucher merged commit b205ac7 into main Apr 13, 2024
5 checks passed
@apgoucher apgoucher deleted the faster_jit branch April 13, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants