You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I have installed the action in accordance with the README.md, such that I have 3 labels:
label a requires 0 reviews
label b requires 1 reviews
label c requires 2 reviews
Steps to reproduce the unexpected behavior:
I open a PR with some changes
I add the b label (such that 1 review is required)
the check (titled pull_request) fails (expectedly, since there are no reviews) and I cannot merge
Someone else approves my PR
A new check (titled pull_request_review) succeeds (due to the approval) but the previous pull_request check is still present and failed and I still cannot merge
Is it possible to fix this (without manually re-running the checks)?
Click to see my (very standard) configuration
.github/workflows/label-reviews.yml
# This workflow will set a number or reviewers depending on the labelsname: Label Reviews# Trigger the workflow on pull requestson:
pull_request:
types:
- opened
- reopened
- synchronize
- labeled
- unlabeledpull_request_review:
types:
- submitted
- edited
- dismissedjobs:
require-reviewers:
# Optional: skip check if no relevant label is present# This needs to be kept in sync with the labels being checkedruns-on: ubuntu-lateststeps:
- name: Require-reviewersuses: travelperk/label-requires-reviews-action@1.3.0env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}with:
rules_yaml: | # define which PR labels require how many aprroving reviewers a: 0 b: 1 c: 2
repository settings
The text was updated successfully, but these errors were encountered:
Pull requests already require 1 approval because of the branch protection rule, so the action will run when this first approval comes.
If the tag requires more than 1 approval it will fail and wait for more approvals to come, if no it won't block the pr, but the action is set to run only when approvals come.
I have installed the action in accordance with the README.md, such that I have 3 labels:
label
a
requires 0 reviewslabel
b
requires 1 reviewslabel
c
requires 2 reviewsSteps to reproduce the unexpected behavior:
b
label (such that 1 review is required)pull_request
) fails (expectedly, since there are no reviews) and I cannot mergepull_request_review
) succeeds (due to the approval) but the previouspull_request
check is still present and failed and I still cannot mergeIs it possible to fix this (without manually re-running the checks)?
Click to see my (very standard) configuration
.github/workflows/label-reviews.yml
repository settings
The text was updated successfully, but these errors were encountered: