Deprecate After All #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deprecate the After All feature in favor of Travis native build stages. Because they are native to Travis, stages are a better way to implement waiting for all the jobs to finish. Add a deprecation warning on usage, in the changelog, and in the docs. Use build stages in our own deployment process, and use the new conditional builds, stages, and jobs to limit when the deployment happens, and which branches are built, and to better signal that only tags should be deployed.
Codecov Report
@@ Coverage Diff @@
## master #93 +/- ##
=========================================
+ Coverage 88.88% 88.99% +0.1%
=========================================
Files 5 5
Lines 207 209 +2
Branches 47 48 +1
=========================================
+ Hits 184 186 +2
Misses 19 19
Partials 4 4
Continue to review full report at Codecov.
|
rpkilby
approved these changes
Nov 13, 2017
|
Sounds good. The release will be the test of that, though I'm fairly confident it will work from my experimenting on #91. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecate the After All feature in favor of Travis native build stages. Because they are native to Travis, stages are a better way to implement waiting for all the jobs to finish.
Add a deprecation warning on usage, in the changelog, and in the docs.
Use build stages in our own deployment process, and use the new conditional builds, stages, and jobs to limit when the deployment happens, and which branches are built, and to better signal that only tags should be deployed.
If merged, this will:
wontfixwontfix@rpkilby : I know that the past couple of days have been a flurry of pull requests that I've merged without your review. They were all related to deployment, so I didn't want to hold up the release for them. This one is different, and I'll want a review before I merge it.