Deploy only a wheel to PyPI #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't gitignore the build and dist directories, so that Travis will clean them before it works on the deployment. Don't install an automatically generated egg while creating the wheel. Only upload wheels to PyPI, and since we're doing that, only run the tests once, with the wheel, and skip the test run with the sdist (the Tox default).
Codecov Report
@@ Coverage Diff @@
## master #87 +/- ##
=======================================
Coverage 88.88% 88.88%
=======================================
Files 5 5
Lines 207 207
Branches 47 47
=======================================
Hits 184 184
Misses 19 19
Partials 4 4Continue to review full report at Codecov.
|
rpkilby
reviewed
Nov 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only gotcha I can think of for this is if somehow it's running on a really old version of pip. But I think that should be a non-issue on Travis. If it is an issue, I would expect us to have already seen it, since we are installing wheels in every job anyway.