Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor #79

Merged
merged 2 commits into from
Oct 19, 2017
Merged

Refactor #79

merged 2 commits into from
Oct 19, 2017

Conversation

ryanhiebert
Copy link
Collaborator

This is the first two commits from #78, since it looks like it's going to take some more effort to complete that one.

@ryanhiebert ryanhiebert changed the title Split Refactor Oct 18, 2017
@codecov-io
Copy link

codecov-io commented Oct 18, 2017

Codecov Report

Merging #79 into master will decrease coverage by 0.13%.
The diff coverage is 68.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #79      +/-   ##
==========================================
- Coverage    75.4%   75.26%   -0.14%     
==========================================
  Files           4        5       +1     
  Lines         187      186       -1     
  Branches       46       45       -1     
==========================================
- Hits          141      140       -1     
  Misses         39       39              
  Partials        7        7
Impacted Files Coverage Δ
src/tox_travis/after.py 57.64% <ø> (-1.91%) ⬇️
src/tox_travis/toxenv.py 94.44% <ø> (+4.08%) ⬆️
src/tox_travis/hacks.py 55.55% <55.55%> (ø)
src/tox_travis/hooks.py 86.66% <80%> (+6.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3c99ab...45309d5. Read the comment docs.

Copy link
Member

@rpkilby rpkilby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems sensible to me - moves the various TRAVIS environ checks to the tox configure hook.

@ryanhiebert ryanhiebert merged commit e83cadf into master Oct 19, 2017
@ryanhiebert ryanhiebert deleted the split branch October 21, 2017 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants