Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move toxenv to tox_configure hook #78

Merged
merged 3 commits into from
Oct 28, 2017
Merged

Move toxenv to tox_configure hook #78

merged 3 commits into from
Oct 28, 2017

Commits on Oct 21, 2017

  1. Configuration menu
    Copy the full SHA
    f28adbb View commit details
    Browse the repository at this point in the history
  2. Configure envlist in tox_configure

    This is a cleaner method of configuring the desired envs to run,
    by overriding tox's config.envlist.
    
    There are a few things worth noting:
    
    1. Because we override envlist directly, instead of proxying
       through the TOXENV environment variable, it eliminates an
       inconsistency where all envs run when no environments are
       detected to run, because TOXENV was set to the empty string
       and ignored.
    2. Because we override envlist later, we must also check manually
       for envs passed directly into tox, so we don't override in
       that case (config.option.env).
    3. To maintain backward compatibility, envs that don't exist
       in the tox.ini aren't automatically created like they are
       when using the TOXENV environment variable, so we have to
       manually add the envconfigs necessary for those.
    4. All references to TOXENV are abandoned.
    ryanhiebert committed Oct 21, 2017
    Configuration menu
    Copy the full SHA
    ffdcb16 View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2017

  1. Configuration menu
    Copy the full SHA
    2e80f1f View commit details
    Browse the repository at this point in the history