Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more built-in exceptions #92

Open
2 tasks
Archmonger opened this issue Jan 12, 2022 · 4 comments
Open
2 tasks

Add more built-in exceptions #92

Archmonger opened this issue Jan 12, 2022 · 4 comments
Labels
type/feature New feature or request

Comments

@Archmonger
Copy link
Contributor

We're missing a few exception types compared to aiopyarr.

  • InvalidCommand
  • CannotCancelCommand
@Archmonger Archmonger added the type/feature New feature or request label Jan 12, 2022
@marksie1988
Copy link
Collaborator

Never even knew someone had taken the code to do that, the next release I was going to do was aio... But yea the exceptions were an initial release so will need more work

@Archmonger
Copy link
Contributor Author

Archmonger commented Jan 12, 2022 •
edited
Loading

I too had only learned about this today. It seems to have been born from an immediate need for an async Sonarr/Radarr API library to use in Home Assistant

@marksie1988
Copy link
Collaborator

Yea that's why I was about to create the aio version. Was about to set it up with the same name too 😂 ok saves me a job I guess

@Archmonger
Copy link
Contributor Author

Let's continue this discussion over on #67

@Archmonger Archmonger mentioned this issue Jan 24, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

PyArr Async Support Archmonger/PyArr
2 participants
@marksie1988 @Archmonger