Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't compile on macos due to alsa #71

Closed
Vixeliz opened this issue Jan 29, 2023 · 5 comments · Fixed by #69
Closed

Doesn't compile on macos due to alsa #71

Vixeliz opened this issue Jan 29, 2023 · 5 comments · Fixed by #69
Labels
bug Something isn't working

Comments

@Vixeliz
Copy link

Vixeliz commented Jan 29, 2023

due to this line in the cargo toml:

alsa = "=0.6.0"
.

It won't compile on macos for now I just cloned into my project and changed it but would be nice to see an upstream fix if possible. Awesome crate!

@torsteingrindvik torsteingrindvik added the bug Something isn't working label Jan 29, 2023
@torsteingrindvik
Copy link
Owner

Thanks for the report.
I'll try adding a CI workflow which cross compiles before the next release.

@torsteingrindvik
Copy link
Owner

Removed the offending lines you mentioned.
So that should not be an issue in main now.

@Vixeliz
Copy link
Author

Vixeliz commented Feb 17, 2023

Awesome thanks! Out of curiosity why was it a dependency in the first place? Isn’t it a Linux audio library/backend? Not criticizing you all just would love to know if there was a reason considering this crate doesn’t deal with audio afaik

@torsteingrindvik
Copy link
Owner

torsteingrindvik commented Feb 17, 2023

I'm actually not sure either, if I remember correctly there was an issue where Bevy main was broken due to this stuff and it propagated down to this plugin. (EDIT: I found the fix by looking at what the maintainers were saying on Discord)
I either couldn't compile locally or on CI or both... but I agree, ALSA (or audio stuff in general) shouldn't be a part of this plugin's dependency tree.

Right now [dev-dependencies] use Bevy with default features on, so that will bring in audio as a dep for sure.
An optimization for a day with little else to do could be to only enable the features actually needed for examples too.

@Vixeliz
Copy link
Author

Vixeliz commented Feb 17, 2023

Interesting! Again no worries was just honestly curious thanks for getting it fixed in main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants