Support for custom ScalingMode

[DasLixou]

add support for custom ScalingMode. i currently have a scalingmode set in my Camera3dBundle aka PostProcessingInput but it doesnt apply when i use vfx-bag. probably because it is a camera of a camera?

[torsteingrindvik]

I can take a look at this.

I also have to look at ScalingMode since I haven't used it.
Just to make sure, could you describe what you expect to happen and what actually happens?

[DasLixou]

ScalingMode is a thing on the camera that says how it behaves when the target gets resized. the problem seems that the image (target) that it now renderes to doesn't resize to the window size when i get it correctly.

[DasLixou]

Without your plugin (ScalingMode works as expected)

With your plugin (is wrongly scaled)

[torsteingrindvik]

Thank you for the details.
I will look into it as soon as I have time.

[torsteingrindvik]

I attempted a workaround for this by extracting the orthographic projection from the user's input camera, and propagating that to the spawned cameras.

This kinda fixed it, but there were some other bugs.

But this all boils down to issues due to spawning cameras for effects.
Now with Bevy 0.9 there is a proper way to do post processing.

I am going to port this entire plugin to use that approach, and then there will be no cameras spawned, and I expect the issue to go away.

Therefore I consider this bug blocked on #45 .

[DasLixou]

Oh LOL i also started a Little vfx Library today to see how far I can come and also make it not use cameras lmao 🤣.

[DasLixou]

@torsteingrindvik seems like i found the issue. Your image to what the camera displays its thing on won't rescale. i made a system that makes it in my library (it currently doesn't show it but it gets piped trough correctly :D ) which resizes the images to the end-target. here if u wanna see: LixouStudios/bevy_vfx@cb8f3c6

[torsteingrindvik]

@DasLixou thanks.

I have started on a plugin rework now though so I don't expect this issue to linger for very long.

[DasLixou]

@DasLixou thanks.

I have started on a plugin rework now though so I don't expect this issue to linger for very long.

Are you going to use RenderGraphs? @torsteingrindvik

[DasLixou]

@torsteingrindvik would you make the plugin rework on a public branch? I would like to contribute a little bit :)

[torsteingrindvik]

It will use render graphs, and yes it will be public when I have landed on an approach.

[DasLixou]

It will use render graphs, and yes it will be public when I have landed on an approach.

Cool 😎

[torsteingrindvik]

After the rework this plugin should behave the same as Bevy proper for scalingmode.
If this is still relevant to you and you try this out let me know how it goes.

[DasLixou]

😎