wip: rewrite assertion diff report #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## improved_assertion_diff #150 +/- ##
==========================================================
Coverage ? 99.53%
==========================================================
Files ? 16
Lines ? 857
Branches ? 0
==========================================================
Hits ? 853
Misses ? 4
Partials ? 0 |
iamogbz
added a commit
that referenced
this pull request
Mar 7, 2020
* wip: rewrite assertion diff report * wip: add colours, more context? * wip: refactor staged line logic * wip: linting * wip: rewrite assertion diff report (#150) * wip * wip * wip * wip * wip * wip * wip * refactor: replace generator type with iterator * refactor: limit context using generators * refactor: reduce diff * refactor: add note about impossible cases * test: hidden characters * chore: update changelog * chore: update changelog * test: diff reporter * lint: shorten line * test: more snapshot test cases * fix: allow context style to work in all backgrounds Co-authored-by: Emmanuel Ogbizi-Ugbe <iamogbz+github@gmail.com> Co-authored-by: Emmanuel Ogbizi <emmanuel.ogbizi-ugbe@tophatmonocle.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
e.g. This PR refactors the X submodule, applying Y's algorithm to improve Z by K percent.
Related Issues
Checklist
Additional Comments
No additional comments.