Make dependency-group-timeout check ignored until all tasks scheduled #623
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug Fix
When some resources are not satisfied and the conf of dependency-timeout-check is specified, it will throw exception. like:
Solution
To get the accurate running tasks info, we should make dependency-group-timeout check ignored until all tasks scheduled.
Tips:
I add the test case for above meeting problems, if you remove the
MLGenericRuntime.groupDependencyTimeout
, and then you could rerun thistestPartialTaskScheduledShouldPass
test case and reproduce the problem.