[MINOR] Support specify timeout for AM waiting for client signal stop #518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@oliverhu Please review it. Thanks. |
|
@zuston please check the tests failures first.. |
|
pls resolve the conflicts |
Sorry, CI test cost too much time. Sometimes I forget checking its status.
OK. |
oliverhu
approved these changes
Mar 26, 2021
zuston
added a commit
to zuston/TonY
that referenced
this pull request
Apr 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
In once loop of
monitorApplicationmethod, when costing too much time over 15s , AM will finished, not waiting TonY client stop signal.So AM rpc service will closed. But TonY client will call updateTaskInfos method, it will cause exception.
I think it's necessary to allow specify AM waiting timeout, because we extend the ClusterSubmmitter to support
TaskUpdateListener, which may cost too much time inmonitorApplicationonce loop.