Reserve evaluator host spec in TF_CONFIG cluster, only when in evaluator process #515
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
To fix bug that evaluator will throw exception when in estimator multiworker strategy.
Why
According to the previous PR, in order to be compatible with PS v2, we need to remove the evaluator from the TF_CONFIG cluster.
After testing the estimator (with TF1.x PS strategy), it works well.
However, recently I encountered the use of estimator multiworker strategy under TF1.x, and I found it reported an error. The error is as follows:
Therefore, I think we should keep the evaluator configuration only when in evaluator process env.
Why is there such a strange problem? I think this is a design problem of the TF estimator and I also can't find some detailed doc.
In this patch, TF_CONFIG will as like following.
For Chief/Woker/PS
For Evaluator