Portal updates #399
Merged
Portal updates #399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When an application is killed by the user, there is no opportunity for a graceful shutdown and those files are never renamed from .jhist.inprogress to the final application status such as -FAILED.jhist or -SUCCEEDED.jhist causing those applications to be interpreted by TonY as currently RUNNING on TonY portal even though they have been terminated. This fix renames those files to -KILLED.jhist, correctly identifying the final status of those killed applications.
This fix adds a parameter to the data table to maintain the default ordering of the TonY jobs and increases the default number of records from 10 to 25.
Tests not passing due to issues with yarn environment. Refactored code to eliminate creating separate yarn client object in test class.
…o portal_updates
This update adds a yarnclient mock to the HistoryFileMoverTest in order to bypass the yarn requirements of the main HistoryFileMover class. This update also adjusts the yarn client initializetion of the main class to once when the mover starts and not each time the killedAppIds function is called.
oliverhu
approved these changes
Oct 24, 2019
i-ony
added a commit
that referenced
this pull request
Oct 25, 2019
Updates project version to 0.3.23
i-ony
added a commit
that referenced
this pull request
Oct 25, 2019
Updates project version to 0.3.23
i-ony
added a commit
that referenced
this pull request
Oct 25, 2019
Updates project version to 0.3.23
i-ony
added a commit
that referenced
this pull request
Oct 25, 2019
Updates project version to 0.3.23
oliverhu
pushed a commit
that referenced
this pull request
Oct 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Adds mocks to HistoryFileMoverTest
-Refactors HistoryFileMover