Updates the order of TonY Portal records and adds UI for user sorting/filtering #354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When viewing the TonY Portal page, the records are displayed in a random order. This fix displays TonY records sorted by most recent process completion date.
When printing a JobMetadata object using the built in toString() method, a string representation of the object is printed rather than the metadata associated with each object (id, user, started, completed, etc). This fix prints out the associated values for each JobMetadata object when using the toString() method.
In my original toString() function, I included new lines in the returned string to better display the output. It’s preferable in this case to retain the default output and allow the user to construct their own custum string. Also in this change, I perform a minor fix to merge the first two string segments of the output where before they were separate strings.
In my original toString() function, I included new lines in the returned string to better display the output. It’s preferable in this case to retain the default output and allow the user to construct their own custum string. Also in this change, I perform a minor fix to merge the first two string segments of the output where before they were separate strings.
On the TonY portal, jobs are currently ordered by completed date. However jobs that are in progress (without a completed date) retain a random order. This change fixes this issue by ordering records first by completed date (desc), then by started date( desc), and then by username (asc). Therefore, if multiple records have identical completed date timestamps these records will be ordered by start date. And if multiple records have identical start and complete timestamps, then these will be ordered by username.
Adds updates to JobsMetadataPageController.java *Sorts TonY Portal records by complete date, start date, and username
oliverhu
reviewed
Jul 18, 2019
|
|
||
| <script src="https://code.jquery.com/jquery-3.3.1.slim.min.js" integrity="sha384-q8i/X+965DzO0rT7abK41JStQIAqVgRVzpbzo5smXKp4YfRvH+8abtTE1Pi6jizo" crossorigin="anonymous"></script> | ||
| <link rel="stylesheet" type="text/css" href="https://cdn.datatables.net/1.10.19/css/jquery.dataTables.css"> |
There was a problem hiding this comment.
let's download all these resources into resource folder
There was a problem hiding this comment.
@oliverhu Addressed comment, please take a look.
|
@StanfordMCP , can you upload a screenshot of what the new UI looks like with sorting and filtering capabilities? |
erwa
approved these changes
Jul 18, 2019
|
@erwa This is a screenshot of the updated UI, in this version (not yet committed) I added footer filters to search by column.
|
|
Very cool! Love the new UI. |
|
@erwa looks like you are just wfh 😄 |
|
Just checking in on how our fish TonY is doing :). You need to feed it daily and clean its water tank from time to time. |
erwa
approved these changes
Jul 23, 2019
There was a problem hiding this comment.
Looks good overall. A few minor comments.
Also, it looks like you have both the regular and minified versions of many JS and CSS files checked in -- e.g.:
- jquery.dataTables.js and jquery.dataTables.min.js
- jquery.dataTables.css and jquery.dataTables.min.css
- etc.
Can we only check in the minified versions to save space?
Currently on the TonY Portal, by default records are sorted first by completed date, then started date, then user id. There is no user initiated sorting or filtering functionality. This update adds the ability to sort by column and filter by keyword. In addition, Bootstrap is added to enhance the table format.
When utilizing the TonY portal, users will need to be online in order to enable the sorting/filtering mechanism of the TonY portal in addition to bootstrap formatting due to the usage of CDNs of various packages such as bootstrap, jquery, and datatables. This update replaces the original CDNs with local copies of the relevant files in order for TonY portal to work offline in addition to online.
|
@erwa removed extraneous non-min files |
erwa
approved these changes
Jul 24, 2019
|
In https://travis-ci.org/linkedin/TonY/builds/562851319?utm_source=github_status&utm_medium=notification, BrowserTest (line 4242) failed with @StanfordMCP , can you take a look and fix this? |
Encountered an issue in which assets are not present in the classloader during testPlayBinary, but are present during runPlayBinary. Will open an issue on the Play Git repo for them to take a look. In the meantime, this fix adds the project directory to the classpath in order for the assets to load during testPlay. In addition, this commit fixes a minor formatting issue in tableMetadata.scala.html.
|
@erwa added fixes, please take a look. |
UWFrankGu
requested changes
Aug 5, 2019
Java jdk updated to openjdk8 from oraclejdk8. Change was done to pass travis CI as per UWFrankGu's comment.
|
@UWFrankGu addressed comment, please check. |
UWFrankGu
approved these changes
Aug 5, 2019
|
Nice work! Also, thanks for fixing the build! |
i-ony
added a commit
that referenced
this pull request
Aug 6, 2019
Updates project version to 0.3.21
i-ony
added a commit
that referenced
this pull request
Aug 6, 2019
Updates project version to 0.3.21
i-ony
added a commit
that referenced
this pull request
Aug 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix updates the TonY Portal to sort records chronologically. This update also adds a Datatable framework to provide users the ability to sort records by column and to filter records based on individual keywords.