Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silence gaps introduce pops in output file. #24

Closed
jarbot opened this issue Sep 29, 2014 · 3 comments
Closed

Silence gaps introduce pops in output file. #24

jarbot opened this issue Sep 29, 2014 · 3 comments

Comments

@jarbot
Copy link

jarbot commented Sep 29, 2014

Suddenly audio distortions have started to appear in our audiosprites files. We're not sure if it's a change to node or what but here is a fix:

(In appendSilence function line 231)

buffer.fill(null)

becomes

buffer.fill(0)

I'm running node v0.11.12 and ffmpeg 2.2.3

Previously I had ffmpeg 1.2 and the pops/cracks were still in the generated file. Upgrading ffmpeg did not resolve the issue.

@tonistiigi
Copy link
Owner

Thanks for the report. For the reference, the change to Node is in nodejs/node-v0.x-archive@4b40358

@tonistiigi
Copy link
Owner

The issue that caused it is now also fixed in node-master nodejs/node-v0.x-archive#8469

@jarbot
Copy link
Author

jarbot commented Sep 30, 2014

Awesome! thank you @tonistiigi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants