Skip to content

Commit

Permalink
fix: after updating next_wake, we drop the locks
Browse files Browse the repository at this point in the history
  • Loading branch information
wathenjiang committed Jul 11, 2024
1 parent c8f3539 commit 01ccab7
Showing 1 changed file with 9 additions and 5 deletions.
14 changes: 9 additions & 5 deletions tokio/src/runtime/time/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -190,18 +190,22 @@ impl Driver {
assert!(!handle.is_shutdown());

// Finds out the min expiration time to park.
let expiration_time = (0..rt_handle.time().inner.get_shard_size())
.filter_map(|id| {
let lock = rt_handle.time().inner.lock_sharded_wheel(id);
lock.next_expiration_time()
})
let locks = (0..rt_handle.time().inner.get_shard_size())
.map(|id| rt_handle.time().inner.lock_sharded_wheel(id))
.collect::<Vec<_>>();

let expiration_time = locks
.iter()
.filter_map(|lock| lock.next_expiration_time())
.min();

rt_handle
.time()
.inner
.next_wake
.store(next_wake_time(expiration_time));
// Safety: After updating next_wake, we drop the locks.
drop(locks);

match expiration_time {
Some(when) => {
Expand Down

0 comments on commit 01ccab7

Please sign in to comment.