Teghan/build one dockerfile #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…les (unitycatalog#544) **PR Checklist** - [x] A description of the changes is added to the description of this PR. - [ ] If there is a related issue, make sure it is linked to this PR. - [ ] If you've fixed a bug or added code that should be tested, add tests! - [ ] If you've added or modified a feature, documentation in `docs` is updated **Description of changes** Fix a bug where the path variables for UpdateModelVersion and UpdateRegisteredModel were being ignored in favor of the incorrectly added variables in the request object. - Request object has been fixed - Path variables are passed in correctly for both handlers and used - All existing code that relied on extraneous fields in generated code has been fixed - All tests continue to pass
…ocs (unitycatalog#469) **PR Checklist** - [x] A description of the changes is added to the description of this PR. - [ ] If there is a related issue, make sure it is linked to this PR. - [ ] If you've fixed a bug or added code that should be tested, add tests! - [ ] If you've added or modified a feature, documentation in `docs` is updated **Description of changes** Added owner, createdBy and updatedBy to all securable info objects and database tables Regenerated openAPI docs Updated the id names for model versions and registered models Signed-off-by: Teghan Nightengale <tnightengale@gmail.com>
Signed-off-by: Teghan Nightengale <tnightengale@gmail.com>
Signed-off-by: Teghan Nightengale <tnightengale@gmail.com>
Signed-off-by: Teghan Nightengale <tnightengale@gmail.com>
Signed-off-by: Teghan Nightengale <tnightengale@gmail.com>
Signed-off-by: Teghan Nightengale <tnightengale@gmail.com>
Signed-off-by: Teghan Nightengale <tnightengale@gmail.com>
**PR Checklist** - [ ] A description of the changes is added to the description of this PR. - [ ] If there is a related issue, make sure it is linked to this PR. - [ ] If you've fixed a bug or added code that should be tested, add tests! - [ ] If you've added or modified a feature, documentation in `docs` is updated **Description of changes** <!-- Please state what you've changed and how it might affect the users. --> Format the test file using javafmtAll Signed-off-by: Teghan Nightengale <tnightengale@gmail.com>
Signed-off-by: Teghan Nightengale <tnightengale@gmail.com>
Signed-off-by: Teghan Nightengale <tnightengale@gmail.com>
Signed-off-by: Teghan Nightengale <tnightengale@gmail.com>
Signed-off-by: Teghan Nightengale <tnightengale@gmail.com>
Signed-off-by: Teghan Nightengale <tnightengale@gmail.com>
**PR Checklist** - [x] A description of the changes is added to the description of this PR. - [ ] If there is a related issue, make sure it is linked to this PR. - [ ] If you've fixed a bug or added code that should be tested, add tests! - [ ] If you've added or modified a feature, documentation in `docs` is updated **Description of changes** Enable identity tracking for all create and update paths for securables in UC OSS Signed-off-by: Teghan Nightengale <tnightengale@gmail.com>
**PR Checklist** - [x] A description of the changes is added to the description of this PR. - [ ] If there is a related issue, make sure it is linked to this PR. - [ ] If you've fixed a bug or added code that should be tested, add tests! - [ ] If you've added or modified a feature, documentation in `docs` is updated **Description of changes** Specify release settings for spark connector Signed-off-by: Teghan Nightengale <tnightengale@gmail.com>
This PR is to test parquet table creation by create table or create table select as Signed-off-by: Teghan Nightengale <tnightengale@gmail.com>
Signed-off-by: Teghan Nightengale <tnightengale@gmail.com>
Signed-off-by: Teghan Nightengale <tnightengale@gmail.com>
Signed-off-by: Teghan Nightengale <tnightengale@gmail.com>
**PR Checklist** - [x] A description of the changes is added to the description of this PR. - [ ] If there is a related issue, make sure it is linked to this PR. - [ ] If you've fixed a bug or added code that should be tested, add tests! - [ ] If you've added or modified a feature, documentation in `docs` is updated **Description of changes** Fix a few issues in the 0.2.0 release process. - explicitly specify release settings on a few subprojects - fix some cross-building issues - move `controlApi` dependency to CLI project, it doesn't need to be published / marked as a spark dependency Signed-off-by: Teghan Nightengale <tnightengale@gmail.com>
**PR Checklist** - [x ] A description of the changes is added to the description of this PR. - [ ] If there is a related issue, make sure it is linked to this PR. - [ ] If you've fixed a bug or added code that should be tested, add tests! - [ ] If you've added or modified a feature, documentation in `docs` is updated **Description of changes** Users can browse models in the UI, view details of models, including versions. Version details page displays version data (created_by and updated_by coming soon with access control changes). <img width="1299" alt="Screenshot 2024-09-10 at 12 15 43 PM" src="https://github.com/user-attachments/assets/1591390b-d986-4ab3-8d2e-9c1bf66fcb97"> <img width="1392" alt="Screenshot 2024-09-10 at 12 16 02 PM" src="https://github.com/user-attachments/assets/2982ed79-91d2-49a9-8391-f31861e3a9fe"> <img width="1304" alt="Screenshot 2024-09-10 at 12 16 15 PM" src="https://github.com/user-attachments/assets/9dc8340e-8bc5-4e9f-80a9-242c3808e26e"> <img width="397" alt="Screenshot 2024-09-10 at 12 36 31 PM" src="https://github.com/user-attachments/assets/6c69a6a9-7864-479b-9078-06ab63c5f45b"> Signed-off-by: Teghan Nightengale <tnightengale@gmail.com>
**PR Checklist** - [x] A description of the changes is added to the description of this PR. - [ ] If there is a related issue, make sure it is linked to this PR. - [ ] If you've fixed a bug or added code that should be tested, add tests! - [ ] If you've added or modified a feature, documentation in `docs` is updated **Description of changes** <!-- Please state what you've changed and how it might affect the users. --> Added temporary path credentials openapi spec and implementation Signed-off-by: Teghan Nightengale <tnightengale@gmail.com>
…log#445) **PR Checklist** - [X] A description of the changes is added to the description of this PR. - [ ] If there is a related issue, make sure it is linked to this PR. - [ ] If you've fixed a bug or added code that should be tested, add tests! - [ ] If you've added or modified a feature, documentation in `docs` is updated **Description of changes** Invalid entity type leads to Null pointer Exception in output. This change makes sure that entity type is validated first before further checks. (entering a invalid entity type into bin/uc) Before the fix: ``` derek@dev-linux unitycatalog (main) $ bin/uc sdfjio Please provide an operation. Please provide a valid sub-command for sdfjio. Exception in thread "main" java.lang.NullPointerException: Cannot invoke "java.util.Map.keySet()" because "entityOptions" is null at io.unitycatalog.cli.utils.CliUtils.printEntityHelp(CliUtils.java:525) at io.unitycatalog.cli.UnityCatalogCli.validateCommand(UnityCatalogCli.java:177) at io.unitycatalog.cli.UnityCatalogCli.main(UnityCatalogCli.java:105) ``` After the fix: ``` derek@dev-linux unitycatalog (fix_npe) $ bin/uc sdfjio Invalid entity provided: sdfjio Usage: bin/uc <entity> <operation> [options] Entities: schema, volume, model_version, auth, catalog, function, registered_model, user, table By default, the client will connect to UC running locally at http://localhost:8080 To connect to specific UC server, use --server https://<host>:<port> Currently, auth using bearer token is supported. Please specify the token via --auth_token <PAT Token> For detailed help on entity specific operations, use bin/uc <entity> --help ``` Co-authored-by: yaoderek <yaoderek@outlook.com> Co-authored-by: Denny Lee <denny.g.lee@gmail.com> Signed-off-by: Teghan Nightengale <tnightengale@gmail.com>
**PR Checklist** - [x] A description of the changes is added to the description of this PR. - [ ] If there is a related issue, make sure it is linked to this PR. - [ ] If you've fixed a bug or added code that should be tested, add tests! - [ ] If you've added or modified a feature, documentation in `docs` is updated **Description of changes** - Removed the warning message. See [discussion](unitycatalog#349 (comment)). - Add a title, an intro and an [image](https://github.com/unitycatalog/unitycatalog#interact-with-the-unity-catalog-ui). - As an idea, **I add a broken link** - [UI Documentation](https://github.com/unitycatalog/unitycatalog/tree/main/docs/ui). - Update the Get started section. - Add a References section to notate the merged. - Commented out Authenticate and Login section. Please let me know what you think. <!-- Please state what you've changed and how it might affect the users. --> --------- Signed-off-by: Juan Diaz <juanchodis@hotmail.com> Signed-off-by: Teghan Nightengale <tnightengale@gmail.com>
**PR Checklist** - [x] A description of the changes is added to the description of this PR. - [ ] If there is a related issue, make sure it is linked to this PR. - [ ] If you've fixed a bug or added code that should be tested, add tests! - [ ] If you've added or modified a feature, documentation in `docs` is updated **Description of changes** We don't want the dependency resolvers to pull in an extra version of spark Signed-off-by: Teghan Nightengale <tnightengale@gmail.com>
**PR Checklist** - [ x] A description of the changes is added to the description of this PR. - [ ] If there is a related issue, make sure it is linked to this PR. - [ ] If you've fixed a bug or added code that should be tested, add tests! - [ ] If you've added or modified a feature, documentation in `docs` is updated **Description of changes** Add the `owner` `created_by` and `updated_by` fields to all other entities (models already has them from previous PR). If the fields are populated, they will display in the details sidebar of each entity. Also, removing non-functional "add/edit description" button from version details page (missed this straggler in previous PR). Signed-off-by: Teghan Nightengale <tnightengale@gmail.com>
…UC OSS (unitycatalog#448) **PR Checklist** - [ ] A description of the changes is added to the description of this PR. - [ ] If there is a related issue, make sure it is linked to this PR. - [ ] If you've fixed a bug or added code that should be tested, add tests! - [ ] If you've added or modified a feature, documentation in `docs` is updated **Description of changes** Added a script that acts as an integration test. Signed-off-by: Teghan Nightengale <tnightengale@gmail.com>
…nitycatalog#427) **PR Checklist** - [x] A description of the changes is added to the description of this PR. - [x] If there is a related issue, make sure it is linked to this PR. - [x] If you've fixed a bug or added code that should be tested, add tests! - [x] If you've added or modified a feature, documentation in `docs` is updated **Description of changes** Fixes unitycatalog#425 Co-authored-by: Tathagata Das <tathagata.das1565@gmail.com> Signed-off-by: Teghan Nightengale <tnightengale@gmail.com>
Signed-off-by: Teghan Nightengale <tnightengale@gmail.com>
**PR Checklist** - [x] A description of the changes is added to the description of this PR. - [ ] If there is a related issue, make sure it is linked to this PR. - [ ] If you've fixed a bug or added code that should be tested, add tests! - [ ] If you've added or modified a feature, documentation in `docs` is updated **Description of changes** Name validation may fail when creating a new catalog, but it always shows a general error message which can be misleading. Add a detailed message to the error hint to help users fix their catalog name inputs. Before:  After: <img width="1229" alt="image" src="https://github.com/user-attachments/assets/4dc8bdbc-bec0-48a4-9134-035d68e54b87"> Signed-off-by: Teghan Nightengale <tnightengale@gmail.com>
**PR Checklist** - [ ] A description of the changes is added to the description of this PR. - [ ] If there is a related issue, make sure it is linked to this PR. - [ ] If you've fixed a bug or added code that should be tested, add tests! - [ ] If you've added or modified a feature, documentation in `docs` is updated **Description of changes** As the title says Signed-off-by: Teghan Nightengale <tnightengale@gmail.com>
**PR Checklist** - [ ] A description of the changes is added to the description of this PR. - [ ] If there is a related issue, make sure it is linked to this PR. - [ ] If you've fixed a bug or added code that should be tested, add tests! - [ ] If you've added or modified a feature, documentation in `docs` is updated **Description of changes** This feature builds upon the authentication functionality to add access controls to UC server endpoints. - Access control is optionally enabled through server server configuration (`server.authorization=enable`) - Resource endpoints all have access control rules that match access rules for Databricks Unity Catalog. - An access control is defined by a principal, a resource and a privilege. - Principals are currently only user entities. - Access controls are hierarchically applied - A privilege assigned to a resource for a principal is active for all the children. - A command-line interface is available to add, update, and delete authorizations. - The root of the hierarchy is a catalog. - There is a new concept of a metastore, which is primarily a resource to assign server level privileges with. The initial set of privileges defined are - `CREATE CATALOG` - allows the principal to create catalogs - `USE CATALOG` - allows the principal to access/use a catalog - `CREATE SCHEMA` - allows the principal to create schemas within a catalog - `USE SCHEMA` - allows the principal to access/use the schema and child tables - `CREATE_TABLE` - allows the principal to create tables in the schema - `SELECT` - allows the principal to run queries against table(s) - `CREATE_FUNCTION` - allows principal to create functions in the schema - `EXECUTE` - allows the principal to execute function(s) - `CREATE_VOLUME` - allows principal to create volumes in the schema - `READ VOLUME` - allows the principal to access volumes within the catalog - `CREATE MODEL` - allows the principal to create models within a schema The rules are generally more complex than summarized above, check Databricks documentation or the code for more details. The CLI interface provides a new `permission` command. Examples ``` bin/uc permission create --securable_type catalog \ --name mycatalog --principal user@myorg.com --privilege "CREATE CATALOG` bin/uc permission get --securable_type catalog --name unity binuc permission delete --securable_type table \ --name mycatalog.myschema.table --principal user@myorg.com --privilege SELECT ``` The framework attempts to separate the concern of access control from the rest of the request handling and processing through annotation-based configuration, via `@AuthorizeExpression`, `@AuthorizeKey` and `@AuthorizeKeys` added to each service entry point. All requests are routed through the `UnityAccessDecorator` which decodes the request, parameters and authorization configuration to evaluate whether access should be allowed or denied. --------- Co-authored-by: Vikrant Puppala <vikrant.puppala@databricks.com> Co-authored-by: Vikrant Puppala <vikrantpuppala@gmail.com> Co-authored-by: Xiang Xu <xiang.xu@databricks.com>
**PR Checklist** - [ ] A description of the changes is added to the description of this PR. - [ ] If there is a related issue, make sure it is linked to this PR. - [ ] If you've fixed a bug or added code that should be tested, add tests! - [ ] If you've added or modified a feature, documentation in `docs` is updated **Description of changes** Database index names apparently need to be unique. The same name `IDX_NAME` was used in multiple locations. Related Issue unitycatalog#493 Co-authored-by: Vikrant Puppala <vikrant.puppala@databricks.com> Signed-off-by: Teghan Nightengale <tnightengale@gmail.com>
…log#509) **PR Checklist** - [ ] A description of the changes is added to the description of this PR. - [ ] If there is a related issue, make sure it is linked to this PR. - [ ] If you've fixed a bug or added code that should be tested, add tests! - [ ] If you've added or modified a feature, documentation in `docs` is updated **Description of changes** Simple wording change for CLI login process. Signed-off-by: Teghan Nightengale <tnightengale@gmail.com>
**Description of changes** <!-- Please state what you've changed and how it might affect the users. --> In `UCSingleCatalog#createTable`, we should get credentials by path and put the credential into the table properties, so that the underlying `DeltaCatalog` can access the Delta log when creating external delta tables. --------- Signed-off-by: Wenchen Fan <wenchen@databricks.com> Signed-off-by: Wenchen Fan <cloud0fan@gmail.com> Co-authored-by: Bijan Houle <bijanhoule@users.noreply.github.com> Signed-off-by: Teghan Nightengale <tnightengale@gmail.com>
…to-end (unitycatalog#513) **PR Checklist** - [X] A description of the changes is added to the description of this PR. - [ ] If there is a related issue, make sure it is linked to this PR. - [ ] If you've fixed a bug or added code that should be tested, add tests! - [ ] If you've added or modified a feature, documentation in `docs` is updated **Description of changes** Include the rapidstart.md which is an extension to the UC quickstart. It also includes instructions on how to utilize Spark, MLflow, and Auth integrations. <!-- Please state what you've changed and how it might affect the users. --> --------- Signed-off-by: Denny Lee <denny.g.lee@gmail.com> Co-authored-by: Jamie Knight <jamie.knight@databricks.com> Co-authored-by: Bijan Houle <bijanhoule@users.noreply.github.com> Co-authored-by: Kris Concepcion <84737625+kriscon-db@users.noreply.github.com> Co-authored-by: Mocker <1179360+creechy@users.noreply.github.com>
Signed-off-by: Teghan Nightengale <tnightengale@gmail.com>
Signed-off-by: Teghan Nightengale <tnightengale@gmail.com>
Signed-off-by: Teghan Nightengale <tnightengale@gmail.com>
Signed-off-by: Teghan Nightengale <tnightengale@gmail.com>
**PR Checklist** - [ ] A description of the changes is added to the description of this PR. - [ ] If there is a related issue, make sure it is linked to this PR. - [ ] If you've fixed a bug or added code that should be tested, add tests! - [ ] If you've added or modified a feature, documentation in `docs` is updated **Description of changes** <!-- Please state what you've changed and how it might affect the users. --> Signed-off-by: Teghan Nightengale <tnightengale@gmail.com>
**PR Checklist** - [X] A description of the changes is added to the description of this PR. - [ ] If there is a related issue, make sure it is linked to this PR. - [ ] If you've fixed a bug or added code that should be tested, add tests! - [ ] If you've added or modified a feature, documentation in `docs` is updated **Description of changes** Minor formatting pages to the docs/quickstart including the MLflow section. <!-- Please state what you've changed and how it might affect the users. --> Signed-off-by: Teghan Nightengale <tnightengale@gmail.com>
) **PR Checklist** - [ ] A description of the changes is added to the description of this PR. - [ ] If there is a related issue, make sure it is linked to this PR. - [ ] If you've fixed a bug or added code that should be tested, add tests! - [ ] If you've added or modified a feature, documentation in `docs` is updated **Description of changes** This is a follow on to the overall access control feature to add access control to the credential vending endpoints. The access control rules for credential vending follows the same rules as getting the entity. This resolve Issue unitycatalog#501 Signed-off-by: Teghan Nightengale <tnightengale@gmail.com>
…ycatalog#518) **PR Checklist** - [x] A description of the changes is added to the description of this PR. - [ ] If there is a related issue, make sure it is linked to this PR. - [ ] If you've fixed a bug or added code that should be tested, add tests! - [ ] If you've added or modified a feature, documentation in `docs` is updated **Description of changes** <!-- Please state what you've changed and how it might affect the users. --> Signed-off-by: Teghan Nightengale <tnightengale@gmail.com>
**PR Checklist** - [ ] A description of the changes is added to the description of this PR. - [ ] If there is a related issue, make sure it is linked to this PR. - [ ] If you've fixed a bug or added code that should be tested, add tests! - [ ] If you've added or modified a feature, documentation in `docs` is updated Remove `PATH_REFRESH` as it is an unused path operation. <!-- Please state what you've changed and how it might affect the users. --> Co-authored-by: Tathagata Das <tathagata.das1565@gmail.com> Signed-off-by: Teghan Nightengale <tnightengale@gmail.com>
**PR Checklist** - [X] A description of the changes is added to the description of this PR. - [ ] If there is a related issue, make sure it is linked to this PR. - [ ] If you've fixed a bug or added code that should be tested, add tests! - [ ] If you've added or modified a feature, documentation in `docs` is updated **Description of changes** - Fixed various formatting and configuration settings for the docs site. - Added Spark integration - Added Model integration - Includes coded tabs, admonitions, linked tabs, and other docs improvements. <!-- Please state what you've changed and how it might affect the users. --> --------- Signed-off-by: Denny Lee <denny.g.lee@gmail.com> Co-authored-by: Kris Concepcion <84737625+kriscon-db@users.noreply.github.com> Co-authored-by: Bijan Houle <bijanhoule@users.noreply.github.com> Co-authored-by: Tathagata Das <tathagata.das1565@gmail.com>
**PR Checklist** - [x] A description of the changes is added to the description of this PR. - [ ] If there is a related issue, make sure it is linked to this PR. - [ ] If you've fixed a bug or added code that should be tested, add tests! - [ ] If you've added or modified a feature, documentation in `docs` is updated **Description of changes** Fix javadoc generation issue e.g. `unknown tag: AuthorizeKey` Signed-off-by: Teghan Nightengale <tnightengale@gmail.com>
**PR Checklist** - [x] A description of the changes is added to the description of this PR. - [ ] If there is a related issue, make sure it is linked to this PR. - [ ] If you've fixed a bug or added code that should be tested, add tests! - [ ] If you've added or modified a feature, documentation in `docs` is updated **Description of changes** Including auth and UI docs. Slight restructuring of docs hierarchy. Clean up missing link, add cross linking, etc. <!-- Please state what you've changed and how it might affect the users. --> --------- Co-authored-by: Jamie Knight <jamie.knight@databricks.com> Co-authored-by: Shawn Chen <ychshawn@gmail.com> Co-authored-by: Mocker <1179360+creechy@users.noreply.github.com> Co-authored-by: Tathagata Das <tathagata.das1565@gmail.com>
**PR Checklist** - [x] A description of the changes is added to the description of this PR. - [ ] If there is a related issue, make sure it is linked to this PR. - [ ] If you've fixed a bug or added code that should be tested, add tests! - [ ] If you've added or modified a feature, documentation in `docs` is updated **Description of changes** Ability to delete a model version from the UI. <img width="425" alt="Screenshot 2024-09-26 at 2 29 57 PM" src="https://github.com/user-attachments/assets/fb27e047-f642-4221-8ef2-3b5ea96091a5"> <img width="522" alt="Screenshot 2024-09-26 at 2 29 51 PM" src="https://github.com/user-attachments/assets/d3b83207-3b21-44c5-8089-04d5370c3118"> <img width="226" alt="Screenshot 2024-09-26 at 2 29 41 PM" src="https://github.com/user-attachments/assets/b4726f0e-b5ad-4ac5-a1b6-77c9a3aba815"> Signed-off-by: Teghan Nightengale <tnightengale@gmail.com>
**PR Checklist** - [X] A description of the changes is added to the description of this PR. - [ ] If there is a related issue, make sure it is linked to this PR. - [ ] If you've fixed a bug or added code that should be tested, add tests! - [ ] If you've added or modified a feature, documentation in `docs` is updated **Description of changes** - Fixed image loc in UI doc - Added managing users to CLI doc <!-- Please state what you've changed and how it might affect the users. --> Signed-off-by: Teghan Nightengale <tnightengale@gmail.com>
**PR Checklist** - [X] A description of the changes is added to the description of this PR. - [ ] If there is a related issue, make sure it is linked to this PR. - [ ] If you've fixed a bug or added code that should be tested, add tests! - [ ] If you've added or modified a feature, documentation in `docs` is updated **Description of changes** Clarification of Identity providers supported <!-- Please state what you've changed and how it might affect the users. --> Signed-off-by: Denny Lee <denny.g.lee@gmail.com> Signed-off-by: Teghan Nightengale <tnightengale@gmail.com>
Signed-off-by: Teghan Nightengale <tnightengale@gmail.com>
Signed-off-by: Teghan Nightengale <tnightengale@gmail.com>
Signed-off-by: Teghan Nightengale <tnightengale@gmail.com>
**PR Checklist** - [x] A description of the changes is added to the description of this PR. - [x] If there is a related issue, make sure it is linked to this PR. - [x] If you've fixed a bug or added code that should be tested, add tests! - [x] If you've added or modified a feature, documentation in `docs` is updated **Description of changes** <!-- Please state what you've changed and how it might affect the users. --> Only run `build/sbt generate` to update the docs without any other changes Signed-off-by: Vikrant Puppala <vikrant.puppala@databricks.com> Signed-off-by: Teghan Nightengale <tnightengale@gmail.com>
tnightengale
force-pushed
the
teghan/build_one_dockerfile
branch
from
eb2d845
to
c7c35dc
Compare
Signed-off-by: Teghan Nightengale <tnightengale@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
docsis updatedDescription of changes