Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Say even more clearly that you can't trust the client to send their most preferred shares #1330

Closed
ekr opened this issue Nov 6, 2023 · 1 comment

Comments

@ekr
Copy link
Contributor

ekr commented Nov 6, 2023

This vector MAY be empty if the client is requesting a
HelloRetryRequest. Each KeyShareEntry value MUST correspond to a
group offered in the "supported_groups" extension and MUST appear in
the same order. However, the values MAY be a non-contiguous subset
of the "supported_groups" extension and MAY omit the most preferred
groups. Such a situation could arise if the most preferred groups
are new and unlikely to be supported in enough places to make
pregenerating key shares for them efficient.

But see: https://datatracker.ietf.org/doc/draft-davidben-tls-key-share-prediction/

@ekr
Copy link
Contributor Author

ekr commented Feb 17, 2024

Fixed by #1331.

@ekr ekr closed this as completed Feb 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant