Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When saving site as PWA with firefox, icon image does not appear #54

Open
tkshill opened this issue Nov 7, 2020 · 1 comment
Open
Labels
Context: help wanted Extra attention is needed good first issue Good for newcomers Status: Available This issue is free to be worked on. Type: Bug Something isn't working

Comments

@tkshill
Copy link
Owner

tkshill commented Nov 7, 2020

Describe the bug

After trying to install the app as a PWA, the image icon doesn't show up.

20201107_175512

Expected behavior
There should be an image from the favicon showing up.

Smartphone (please complete the following information):

- Device: Galaxy A21s
 - OS: Android 10
 - Browser Firefox Beta 
 - Version 83.0.0 

Additional context

  • Currently, we're keeping the site manifest in the favicon folder. Not sure if that's correct.
  • In the site.webmanifest file we have
{
    "name": "Elm Quarto",
    "short_name": "Elm Quarto",
    "description": "Functional and accessible web app based on the popular (and highly entertaining) board game Quarto.",
    "icons": [
        {
            "src": "/android-chrome-192x192.png",
            "sizes": "192x192",
            "type": "image/png"
        },
        {
            "src": "/android-chrome-512x512.png",
            "sizes": "512x512",
            "type": "image/png"
        }
    ],
    "theme_color": "#000000",
    "background_color": "#ffffff",
    "display": "standalone"
}

We only make mention of android-chrome. It may be necessary to add more to the icons list?

Any help would be appreciated on this.

UPDATE
This web.dev article seems to describe the problem. Apparently, the images in the icons may need a "purpose" field to enable that functionality.


See here in the read me for how to run and install the application.

See here in contributing for the basics on forking and cloning the repository.

@tkshill tkshill added Type: Bug Something isn't working Context: help wanted Extra attention is needed good first issue Good for newcomers Status: Available This issue is free to be worked on. labels Nov 7, 2020
@tkshill tkshill added this to the Progressive Web App milestone Nov 7, 2020
@github-actions
Copy link

github-actions bot commented Nov 7, 2020

Thank you for the issue! We'll take your request into consideration and will follow up soon if we decide to tackle this issue.
To all contributors: any issue that is labeled Status: Available is up for grabs.
To claim an issue to work on, please leave a comment. If you've claimed the issue and need help, please leave a comment letting us know and we can schedule some time to help.
For full info on how to contribute, please check out our contributors guide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Context: help wanted Extra attention is needed good first issue Good for newcomers Status: Available This issue is free to be worked on. Type: Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant