Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nested interpolated media queries and support random interpolations in injectGlobal #265

Merged
merged 2 commits into from
Aug 17, 2017

Conversation

emmatown
Copy link
Member

What:
Fix nested interpolated media queries

Support random interpolations in injectGlobal.

Why:
Closes #262
Closes #254

How:
Don't run postcss-nested on non static styles and use build, deconstruct and deconstructedStyleToCSS in injectGlobal

Checklist:

  • Documentation
  • Tests
  • Code complete

@codecov-io
Copy link

codecov-io commented Aug 17, 2017

Codecov Report

Merging #265 into master will increase coverage by 0.08%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #265      +/-   ##
==========================================
+ Coverage   90.28%   90.37%   +0.08%     
==========================================
  Files          20       21       +1     
  Lines         968      966       -2     
  Branches      261      260       -1     
==========================================
- Hits          874      873       -1     
+ Misses         76       75       -1     
  Partials       18       18
Impacted Files Coverage Δ
packages/emotion/test/pretty-css.js 100% <100%> (ø)
packages/babel-plugin-emotion/src/parser.js 95.12% <100%> (+0.12%) ⬆️
packages/emotion/src/index.js 94.39% <100%> (+0.3%) ⬆️
packages/babel-plugin-emotion/src/ast-object.js 89.36% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4545ac3...063ffa1. Read the comment docs.

@emmatown emmatown requested a review from tkh44 August 17, 2017 12:51
@tkh44 tkh44 merged commit d20f53b into master Aug 17, 2017
@tkh44 tkh44 deleted the fix-nested-interpolated-media-queries branch August 17, 2017 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problems with Media Queries in Pseudo Selectors injectGlobal and friends should support dynamic expressions.
3 participants