-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increment inspector port for spawned subcommands #991
Conversation
I have added tests, and check for (I will update README after decide #990 as I moved |
Added section to README. All done. Ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you.
Available now as a prerelease. See #1001 |
Shipped in v3: https://github.com/tj/commander.js/releases/tag/v3.0.0 |
Look for node inspector arguments used for configuring debugging and increment the port number. This avoids launch errors when debugging git-style subcommands from top-level command.
A call like this which implicitly uses default port of 9229
will spawn a sub-command with port number incremented:
See earlier pull request with research and comments about approach of incrementing ports: #874
Related issues: #533 #838
Code can be reviewed by interested readers.
I have not minimised number of regex calls, could preflight with a simple search?
Opening as draft pull request because no changes yet to README or tests.