Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When files are renamed, the deleted file should point to old filename when output_renamed_files_as_deleted_and_added: true #2234

Closed
Whadup opened this issue Aug 20, 2024 · 1 comment
Closed

When files are renamed, the deleted file should point to old filename when output_renamed_files_as_deleted_and_added: true #2234

Whadup opened this issue Aug 20, 2024 · 1 comment

Comments

@Whadup
Copy link
Contributor

Whadup commented Aug 20, 2024

changed-files/src/changedFiles.ts

Line 487 in 257f12c

changedFiles[ChangeTypeEnum.Deleted].push(item.filename)

Instead of reporting that item.filename was deleted, we should report that item.previous_filename was deleted when the user has set output_renamed_files_as_deleted_and_added=true
@tj-actions-bot
Copy link
Contributor

Thanks for reporting this issue, don't forget to star this project if you haven't already to help us reach a wider audience.

@Whadup Whadup mentioned this issue Aug 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Whadup @jackton1 @tj-actions-bot