Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(svelte): check every <script> #819

Merged
merged 2 commits into from
Mar 11, 2022
Merged

feat(svelte): check every <script> #819

merged 2 commits into from
Mar 11, 2022

Conversation

tivac
Copy link
Owner

@tivac tivac commented Mar 10, 2022

Description

At least until a matching import is found, still bail on the first one for optimization simplicity reasons.

Motivation and Context

Fixes #818

How Has This Been Tested?

Added a test

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

At least until a matching import is found, still bail on the first one for optimization simplicity reasons.

Fixes #818
@ghost
Copy link

ghost commented Mar 10, 2022

CodeSee Review Map:

Review these changes using an interactive CodeSee Map

Review in an interactive map

View more CodeSee Maps

Legend

CodeSee Map Legend

@netlify
Copy link

netlify bot commented Mar 10, 2022

✔️ Deploy Preview for m-css ready!

🔨 Explore the source changes: e133107

🔍 Inspect the deploy log: https://app.netlify.com/sites/m-css/deploys/6229b281d103510008b5f20b

😎 Browse the preview: https://deploy-preview-819--m-css.netlify.app

@codecov
Copy link

codecov bot commented Mar 10, 2022

Codecov Report

Merging #819 (e133107) into main (baee1b1) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #819   +/-   ##
=======================================
  Coverage   99.58%   99.58%           
=======================================
  Files          37       37           
  Lines        1433     1434    +1     
  Branches      232      232           
=======================================
+ Hits         1427     1428    +1     
  Misses          6        6           
Impacted Files Coverage Δ
packages/svelte/script.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update baee1b1...e133107. Read the comment docs.

@tivac tivac merged commit e3be450 into main Mar 11, 2022
@tivac tivac deleted the multiple-scripts branch March 11, 2022 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Preprocessor only looks for imports in the first <script> tag if multiple are present
1 participant