Rework rollup support #531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Broken for dynamic imports though, they're missing info we really need atm.
Dynamic imports still failing: rollup/rollup#2553 (comment)
BREAKING CHANGE: reworked CSS so it better matches rollup output chunk format Also removed extraneous "rollup" directory from test output for easier visibility.
To avoid any ugly double-hashed filenames. Fixes #525
It's not stable on other machines, which makes snapshots fail all over the place.
There was a dependency ordering bug hiding in the old code, yikes!
Object.entries does what we need w/o any flopping around in a 3rd party lib.
Codecov Report
@@ Coverage Diff @@
## master #531 +/- ##
==========================================
+ Coverage 99% 99.11% +0.11%
==========================================
Files 39 39
Lines 902 907 +5
Branches 137 135 -2
==========================================
+ Hits 893 899 +6
+ Misses 9 8 -1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Take advantage of new functionality in rollup@0.68.0 and also rework the logic in the rollup plugin. Now it handles things like repeated chunk names, better deals with shared assets, and also fixed a nasty timing bug in processor.js that I somehow never caught before.