You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Backups filenames are missing the timestamp as of v3.8.0
Steps to reproduce
Make a backup of a SQLite database with the default settings. (Based on the code I think this is also affecting InfluxDB and MSSQL, but didn't test those)
Observe the backup file has no timestamp in the name (eg: sqlite3_db.sqlite3.xz), and consequently there is no retention of previous backup files.
What is the expected correct behavior?
Backup file should have a timestamp in the name, and a new backup file should be present after each run.
Relevant logs and/or screenshots
** Performing Manual Backup
2023-04-11.22:27:49 [NOTICE] ** [db-backup] Dumping sqlite3 database: '/db.sqlite' and compressing with 'xzip'
2023-04-11.22:27:49 [INFO] ** [db-backup] DB Backup of 'sqlite3_db.sqlite3.xz' completed successfully
2023-04-11.22:27:53 [NOTICE] ** [db-backup] Backup of sqlite3_db.sqlite3.xz created with the size of 37709892 bytes
mv: can't rename '/tmp/backups/*.': No such file or directory
ln: /backup/latest-sqlite3__/db.sqlite: No such file or directory
2023-04-11.22:27:53 [NOTICE] ** [db-backup] DB Backup for 'db' time taken: Hours: 0 Minutes: 00 Seconds: 04
2023-04-11.22:27:53 [INFO] ** [db-backup] Backup routines finish time: 2023-04-11 22:27:53 GMT with overall exit code 0
2023-04-11.22:27:53 [NOTICE] ** [db-backup] Backup routines time taken: Hours: 0 Minutes: 00 Seconds: 04
2023-04-11.22:27:53 [INFO] ** [db-backup] Cleaning up old backups on filesystem
Looks to me like there are several ltarget variables not set properly in install/assets/functions/10-db-backup for the 3 DB types I mentioned above. I'll open a PR.
The text was updated successfully, but these errors were encountered:
Summary
Backups filenames are missing the timestamp as of v3.8.0
Steps to reproduce
sqlite3_db.sqlite3.xz
), and consequently there is no retention of previous backup files.What is the expected correct behavior?
Backup file should have a timestamp in the name, and a new backup file should be present after each run.
Relevant logs and/or screenshots
Environment
docker-compose.yml
backup: container_name: backup image: tiredofit/db-backup:latest restart: on-failure:5 volumes: - /db.sqlite3:/db.sqlite:ro - /backups:/backup environment: COMPRESSION: "xz" DB_TYPE: "sqlite" DB_HOST: "/db.sqlite" DB_DUMP_BEGIN: "0801" DB_CLEANUP_TIME: "14400" ENABLE_CHECKSUM: "false" CONTAINER_ENABLE_MONITORING: "false"Possible fixes
Looks to me like there are several
ltarget
variables not set properly ininstall/assets/functions/10-db-backup
for the 3 DB types I mentioned above. I'll open a PR.The text was updated successfully, but these errors were encountered: