Crashes bcrypt

[olalonde]

kelektiv/node.bcrypt.js#980

I'm not really sure what this library does and whether it's a bug that can be fixed by bcrypt or tinypool.

[olalonde]

Also getting the same issue with argon2.

[Aslemammad]

Interesting, what do these libraries have in common, that makes the problem related to Tinypool? Do you have any reproductions (not with vitest, with Tinypool only)

[olalonde]

No I don't have a reproduction but the reason that leads me to believe it's an issue with tinypool:

1. I get the error using two different native libraries (the only thing they have in common is that they're native libraries AFAIK)

2. the error only happens when threading is enabled on vitest

[olalonde]

It could also be a bug in some library that tinypool is using, including Node.js implementation of worker_threads ?

[Aslemammad]

maybe, I don't think Tinypool is doing something different, it uses worker_threads! So the issue may be there, and if it is, then the issue is mostly with the libs.

[olalonde]

Or maybe https://nodejs.org/api/async_hooks.html ? It's marked as an experimental API. I'll see if I can isolate the bug.

[Aslemammad]

That'd help so much

[AriPerkkio]

Fixed by #64.