Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vehicle_velocity_converter): add default vehicle_velocity_converter.param.yaml #68

Merged
merged 1 commit into from
Dec 4, 2023

Conversation

KYabuuchi
Copy link
Contributor

@KYabuuchi KYabuuchi commented Dec 4, 2023

Desciption

Added default vehicle_velocity_converter.param.yaml to all sensor_models.

⚠️ The tier4/aip_launcher references this file. ⚠️
In the past, this was not a problem because default parameters were declared in the node.
However, the default parameters have recently been removed. c.f. autowarefoundation/autoware.universe#5609

Also, autowarefaundation/autoware_individual_params does not have this file, but neither sample_sensor_kit_launch nor awsim_sensor_kit_launch refer to it.

Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>
@KYabuuchi KYabuuchi marked this pull request as ready for review December 4, 2023 08:37
Copy link

@shmpwk shmpwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@tkimura4 tkimura4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 🥇

@tkimura4 tkimura4 merged commit 588dd32 into main Dec 4, 2023
11 of 12 checks passed
@tkimura4 tkimura4 deleted the fix/add_vehicle_velocity_converter_param branch December 4, 2023 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants