Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changing disable_index_adjustment in Pipfile does not invalidate cache #1581

Open
fridex opened this issue Jan 4, 2022 · 5 comments
Open

Changing disable_index_adjustment in Pipfile does not invalidate cache #1581

fridex opened this issue Jan 4, 2022 · 5 comments
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/backlog Higher priority than priority/awaiting-more-evidence. sig/stack-guidance Categorizes an issue or PR as relevant to SIG Stack Guidance.

Comments

@fridex
Copy link
Contributor

fridex commented Jan 4, 2022

Describe the bug

Changing disable_index_adjustment does not invalidate cache on user-api.

To Reproduce
Steps to reproduce the behavior:

  1. Add dependencies to Pipfile, e.g. thamos add tensorflow --index-url 'https://tensorflow.pypi.thoth-station.ninja/index/manylinux2010/AVX2/simple'
  2. Ask for an advise
  3. Change disable_index_adjustment in Thoth's section of Pipfile
  4. See cached results returned

Expected behavior

Changing index adjustment should differentiate requests to Thoth.
@fridex fridex added the kind/bug Categorizes issue or PR as related to a bug. label Jan 4, 2022
@goern
Copy link
Member

goern commented Jan 17, 2022

/priority important-soon

@sesheta sesheta added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Jan 17, 2022
@sesheta
Copy link
Member

sesheta commented Apr 17, 2022

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@sesheta sesheta added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 17, 2022
@harshad16
Copy link
Member

/lifecycle frozen

@sesheta sesheta added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Apr 18, 2022
@goern
Copy link
Member

goern commented Jul 19, 2022

is this something we still need to fix? pls review!

@harshad16
Copy link
Member

Maybe something discusses and review in the stack guidance sig.
I don't think this is addressed yet.

/sig stack-guidance

@sesheta sesheta added the sig/stack-guidance Categorizes an issue or PR as relevant to SIG Stack Guidance. label Jul 19, 2022
@goern goern added priority/backlog Higher priority than priority/awaiting-more-evidence. and removed priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. labels Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/backlog Higher priority than priority/awaiting-more-evidence. sig/stack-guidance Categorizes an issue or PR as relevant to SIG Stack Guidance.
Projects
Planning Board
Status: 📋 Backlog
Milestone
No milestone
Development

No branches or pull requests
4 participants
@goern @fridex @harshad16 @sesheta