Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct typing in storages.graph #2735

Open
1 task
VannTen opened this issue Nov 16, 2022 · 0 comments
Open
1 task

Correct typing in storages.graph #2735

VannTen opened this issue Nov 16, 2022 · 0 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence. sig/stack-guidance Categorizes an issue or PR as relevant to SIG Stack Guidance.

Comments

@VannTen
Copy link
Member

VannTen commented Nov 16, 2022

Problem statement

Followup of #2673 / #2674
Code in storages.graph is a bit messy. We should refactor it so it is type correct.
We might use the opportunity to switch to sql-alchemy 2.0 (which seems to be more ergonomic on the typing part, according to their docs)

High-level Goals

Full type safety in the repo.

Acceptance Criteria

  • remove the ovveride in pyproject.toml for storages.graph and fix all errors

/kind feature
/priority backlog
/sig stack-guidance
@VannTen VannTen added the kind/feature Categorizes issue or PR as related to a new feature. label Nov 16, 2022
@sesheta sesheta added priority/backlog Higher priority than priority/awaiting-more-evidence. sig/stack-guidance Categorizes an issue or PR as relevant to SIG Stack Guidance. labels Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence. sig/stack-guidance Categorizes an issue or PR as relevant to SIG Stack Guidance.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@VannTen @sesheta