Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ceph to S3 #2665

Closed
wants to merge 9 commits into from
Closed

Ceph to S3 #2665

wants to merge 9 commits into from

Conversation

VannTen
Copy link
Member

@VannTen VannTen commented Jul 20, 2022

Related Issues and Dependencies

closes #2663

This introduces a breaking change

  • Yes
  • No

-> any code importing CephStore / ceph module would have to rename it to S3

This should yield a new module release

  • Yes
  • No

Description

Mostly, it's a big sed 's/ceph/s3/'.

@sesheta sesheta added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 20, 2022
@sesheta
Copy link
Member

sesheta commented Jul 20, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign mayacostantini after the PR has been reviewed.
You can assign the PR to them by writing /assign @mayacostantini in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sesheta sesheta added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 20, 2022
@sesheta
Copy link
Member

sesheta commented Jul 20, 2022

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@goern goern closed this May 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshad16 harshad16 Awaiting requested review from harshad16

@KPostOffice KPostOffice Awaiting requested review from KPostOffice

Assignees
No one assigned
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

S3 instead of Ceph
3 participants
@VannTen @sesheta @goern