Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add advise to CNBi pipelines #27

Open
codificat opened this issue Oct 31, 2022 · 1 comment
Open

Add advise to CNBi pipelines #27

codificat opened this issue Oct 31, 2022 · 1 comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. wg/cre Issues or PRs related to the Custom Runtime Environment (fka Custom Notebook Image) ODH feature.

Comments

@codificat
Copy link
Member

From the CNBi feature description:

  1. The system must provide users some capability to check dependencies and verify any dependency issues as they are defining the components in a notebook or a new custom image.

    P1: When users create custom NB images, the system should perform some automatic check for dependencies, security issues, and compatibility across components included in the image. The system should present a message with any issues found, but should not prevent users from proceeding.
    P2: The system should provide users an option to check for dependencies, security issues, and compatibility across components prior to attempting to create a custom NB image. This should be an optional tool accessible from the UI. The use case is enabling users to check for issues in a notebook/image prior to the process of trying to create a custom image.
    P2: The system should provide optional guidance to identify dependencies (eg specific package versions needed) at the point of installing packages. For example, a user could add a TensorFlow version in a notebook and the user could access a tool to get recommendations on other package versions to install. Additionally, if a user installs an incompatible version of dependency (eg. the wrong version of scipy to work with the added version of TensorFlow), the user could access a UI option to identify issues and make corrections.

Notes:

This should be an optional tool that is available prior to creating a custom NB image. This could be at the point of installation or after I've installed several components & I want to check the versions & compatibility.

@codificat
Copy link
Member Author

Notes from the backlog grooming session.

About the user experience: we must keep in mind that getting advice from Thoth can be a relatively slow process. Any action involving Thoth advice would not be interactive in the web UI.

Other Thoth API interactions that do not involve advise can be interactive, e.g. to validate or obtain a list of valid/known package versions.

This should be an optional tool that is available prior to creating a custom NB image.

All of this basically implies that Thoth advice and/or any sort of guided dependency check/resolution should have its own, separate pipeline - and a mechanism to trigger it without triggering an image build pipeline.

Also, we will prioritize the build workflows first and work on this afterwards.

/kind feature
/priority important-longterm

@sesheta sesheta added kind/feature Categorizes issue or PR as related to a new feature. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. labels Nov 2, 2022
@sesheta sesheta added the wg/cre Issues or PRs related to the Custom Runtime Environment (fka Custom Notebook Image) ODH feature. label Nov 18, 2022
@sesheta sesheta removed the wg/cnbi label Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. wg/cre Issues or PRs related to the Custom Runtime Environment (fka Custom Notebook Image) ODH feature.
Projects
Status: 🆕 New
Development

No branches or pull requests

2 participants