Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inform users to make them activate issues if they want to recieve Khebut issues #794

Open
pacospace opened this issue Aug 23, 2021 · 13 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. sig/user-experience Issues or PRs related to the User Experience of our Services, Tools, and Libraries. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@pacospace
Copy link
Contributor

Is your feature request related to a problem? Please describe.

  File "/home/user/kebechet/kebechet_runners.py", line 71, in run_webhook
    run_url(url, service_type, parsed_payload)
  File "/home/user/kebechet/kebechet_runners.py", line 92, in run_url
    run(
  File "/home/user/kebechet/kebechet_runners.py", line 195, in run
    _create_issue_from_exception(
  File "/home/user/kebechet/utils.py", line 191, in _create_issue_from_exception
    project.create_issue(title=title, body=body, labels=["bot"])
  File "/home/user/.local/share/virtualenvs/user-5PivF_Od/lib/python3.8/site-packages/ogr/utils.py", line 173, in indirectly_called
    return specialized_function(self, *args, **kwargs)
  File "/home/user/.local/share/virtualenvs/user-5PivF_Od/lib/python3.8/site-packages/ogr/services/github/issue.py", line 108, in create
    github_issue = project.github_repo.create_issue(
  File "/home/user/.local/share/virtualenvs/user-5PivF_Od/lib/python3.8/site-packages/github/Repository.py", line 1218, in create_issue
    headers, data = self._requester.requestJsonAndCheck(
  File "/home/user/.local/share/virtualenvs/user-5PivF_Od/lib/python3.8/site-packages/github/Requester.py", line 353, in requestJsonAndCheck
    return self.__check(
  File "/home/user/.local/share/virtualenvs/user-5PivF_Od/lib/python3.8/site-packages/github/Requester.py", line 378, in __check
    raise self.__createException(status, responseHeaders, output)
github.GithubException.GithubException: 410 {"message": "Issues are disabled for this repo", "documentation_url": "https://docs.github.com/v3/issues/"}

Describe the solution you'd like
Open issue to user repo to make them activate issues

Describe alternatives you've considered
Leave as it is.

Additional context

@pacospace pacospace added kind/feature Categorizes issue or PR as related to a new feature. triage/needs-information Indicates an issue needs more information in order to work on it. labels Aug 23, 2021
@pacospace
Copy link
Contributor Author

pacospace commented Sep 1, 2021

Issue cannot be opened, so we need an alternative:

  • Verify if Khebut can enable issues in the repo where it is installed.

thanks cc @harshad16 @codificat

@pacospace pacospace removed the triage/needs-information Indicates an issue needs more information in order to work on it. label Sep 1, 2021
@goern
Copy link
Member

goern commented Sep 3, 2021

This does not sound like a good idea, we should let the use of kebechet do this as a pre-requisite?!

@pacospace pacospace changed the title Open issue to user repo to make them activate issues Inform users to make them activate issues if they want to recieve Khebut issues Sep 3, 2021
@pacospace
Copy link
Contributor Author

pacospace commented Sep 3, 2021

This does not sound like a good idea, we should let the use of kebechet do this as a pre-requisite?!

Yes, sounds good, when they install Khebut, they should do that, but if they forget how do we reach them? opening a PR with .thoth.yaml maybe and saying "Remember to activate issues if you want to use Thoth services"?

@goern
Copy link
Member

goern commented Sep 3, 2021

ja, sounds good

@goern
Copy link
Member

goern commented Sep 17, 2021

/priority important-soon

@sesheta sesheta added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Sep 17, 2021
@sesheta
Copy link
Member

sesheta commented Dec 16, 2021

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@sesheta sesheta added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 16, 2021
@sesheta
Copy link
Member

sesheta commented Jan 15, 2022

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle rotten

@sesheta sesheta added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jan 15, 2022
@harshad16
Copy link
Member

/life-cycle frozen
/kind feature

@harshad16
Copy link
Member

/lifecycle frozen

@sesheta sesheta added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. labels Jan 17, 2022
@goern
Copy link
Member

goern commented Apr 26, 2022

@harshad16 @KPostOffice is this feature still required?

@harshad16
Copy link
Member

This is good issue.
we should have it for future development.
/triage accepted
/priority important-soon

@sesheta sesheta added the triage/accepted Indicates an issue or PR is ready to be actively worked on. label Apr 26, 2022
@goern
Copy link
Member

goern commented Jul 26, 2022

let's have a look that this workflow/use case again

/triage needs-information
/remove-priority important-soon
/sig user-experience

@sesheta sesheta added triage/needs-information Indicates an issue needs more information in order to work on it. sig/user-experience Issues or PRs related to the User Experience of our Services, Tools, and Libraries. and removed priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Jul 26, 2022
@Gkrumbach07
Copy link
Member

Acceptance Criteria

  • Open an empty PR with a request to switch on issues from the bot

@harshad16 harshad16 removed their assignment Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. sig/user-experience Issues or PRs related to the User Experience of our Services, Tools, and Libraries. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
Status: 🔖 Next
Development

No branches or pull requests

5 participants