Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3pt]Provide a generic advise_manifest_changes in results that can be retrieved and used by thamos #2211

Open
pacospace opened this issue Dec 14, 2021 · 7 comments
Open

[3pt]Provide a generic advise_manifest_changes in results that can be retrieved and used by thamos #2211

pacospace opened this issue Dec 14, 2021 · 7 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/stack-guidance Categorizes an issue or PR as relevant to SIG Stack Guidance.

Comments

@pacospace
Copy link
Contributor

pacospace commented Dec 14, 2021 •
edited
Loading

It might be good to provide a generic mechanism for this advised_manifest_changes so we can generalize the feature. Something like (rough design just to show the functionality):

advised_manifest_changes:
 - file: .thoth.yaml  # File that should be patched (can be also a buildconfig or so).
   patch:
     add: ...

Originally posted by @fridex in thoth-station/thamos#910 (comment)

Related-To: thoth-station/core#308
Related-To: thoth-station/thamos#910
Related-To: thoth-station/prescriptions-refresh-job#87
This was referenced Dec 14, 2021
Closed
Closed
@goern
Copy link
Member

goern commented Dec 21, 2021

/kind bug
/priority important-soon

@sesheta sesheta added kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Dec 21, 2021
@pacospace
Copy link
Contributor Author

/kind bug /priority important-soon

It's actually a feature request :)

@pacospace pacospace added kind/feature Categorizes issue or PR as related to a new feature. and removed kind/bug Categorizes issue or PR as related to a bug. labels Dec 21, 2021
@pacospace pacospace mentioned this issue Dec 22, 2021
Open
12 tasks
@pacospace
Copy link
Contributor Author

hey @fridex do you want me to work on this?

@fridex
Copy link
Contributor

fridex commented Jan 17, 2022

hey @fridex do you want me to work on this?

Feel free to take it. It is not clear to me how a good integration should look like though (and if we should directly support something like this now).

@mayaCostantini
Copy link
Contributor

/assign @mayaCostantini
/sig stack-guidance
/lifecycle active

@sesheta sesheta added lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. sig/stack-guidance Categorizes an issue or PR as relevant to SIG Stack Guidance. labels Mar 16, 2022
@mayaCostantini
Copy link
Contributor

/remove-lifecycle active

@sesheta sesheta removed the lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. label Apr 19, 2022
@mayaCostantini mayaCostantini changed the title Provide a generic advise_manifest_changes in results that can be retrieved and used by thamos [3pt]Provide a generic advise_manifest_changes in results that can be retrieved and used by thamos Jul 18, 2022
@VannTen
Copy link
Member

VannTen commented Oct 20, 2022

/priority backlog

@sesheta sesheta added the priority/backlog Higher priority than priority/awaiting-more-evidence. label Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/stack-guidance Categorizes an issue or PR as relevant to SIG Stack Guidance.
Projects
Planning Board
Status: 📋 Backlog
Milestone
No milestone
Development

No branches or pull requests
7 participants
@goern @fridex @VannTen @pacospace @shreekarSS @sesheta @mayaCostantini