Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5pt]Enhance environment markers with python_version taken from package metadata #2154

Open
2 tasks
fridex opened this issue Nov 1, 2021 · 4 comments
Open
2 tasks

[5pt]Enhance environment markers with python_version taken from package metadata #2154

fridex opened this issue Nov 1, 2021 · 4 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/backlog Higher priority than priority/awaiting-more-evidence. sig/stack-guidance Categorizes an issue or PR as relevant to SIG Stack Guidance. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@fridex
Copy link
Contributor

fridex commented Nov 1, 2021

Is your feature request related to a problem? Please describe.

Pipenv added a new feature where each dependency has the environment marker python_version taken from package metadata. It might be a good idea to include such an environment marker in Thoth's adviser as well. It will not affect the resolution process anyhow, but will create more explicit Pipfile.lock with relevant python_version environment markers.

Describe the solution you'd like

  • sync information about python_version into the database from solver runs
  • propagate python_version information in a form of an environment marker in the resulting lock file

Describe alternatives you've considered

Keep the solution as-is.
@fridex fridex added the kind/feature Categorizes issue or PR as related to a new feature. label Nov 1, 2021
@fridex
Copy link
Contributor Author

fridex commented Nov 1, 2021

This would be a nice feature, but not "must-have". This behavior is partially documented. If users use overlays properly and have their environments setup correctly, this feature has no effect.

/priority backlog
/triage accepted
/sig adviser

@sesheta sesheta added priority/backlog Higher priority than priority/awaiting-more-evidence. triage/accepted Indicates an issue or PR is ready to be actively worked on. sig/adviser labels Nov 1, 2021
@sesheta
Copy link
Member

sesheta commented Jan 30, 2022

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@sesheta sesheta added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 30, 2022
@fridex
Copy link
Contributor Author

fridex commented Jan 31, 2022

/remove-lifecycle stale

@sesheta sesheta removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 31, 2022
@sesheta sesheta added sig/stack-guidance Categorizes an issue or PR as relevant to SIG Stack Guidance. and removed sig/adviser labels Mar 2, 2022
@sesheta
Copy link
Member

sesheta commented Jun 1, 2022

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@sesheta sesheta added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 1, 2022
@mayaCostantini mayaCostantini added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jun 30, 2022
@mayaCostantini mayaCostantini changed the title Enhance environment markers with python_version taken from package metadata [5pt]Enhance environment markers with python_version taken from package metadata Jul 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/backlog Higher priority than priority/awaiting-more-evidence. sig/stack-guidance Categorizes an issue or PR as relevant to SIG Stack Guidance. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
Planning Board
Status: 📋 Backlog
Milestone
No milestone
Development

No branches or pull requests
3 participants
@fridex @sesheta @mayaCostantini