refactor: make arguments optional

thislooksfun · Feb 7, 2021 · d2814df · d2814df
1 parent a839882
commit d2814df
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 12 deletions.
diff --git a/src/Repo.svelte b/src/Repo.svelte
@@ -6,11 +6,11 @@
   export let name: string;
   export let url: string;
   export let isFork: boolean;
-  export let description: string | undefined;
-  export let sourceUrl: string | undefined;
-  export let sourceName: string | undefined;
-  export let language: string | undefined;
-  export let langColor: string | undefined;
+  export let description: string | undefined = undefined;
+  export let sourceUrl: string | undefined = undefined;
+  export let sourceName: string | undefined = undefined;
+  export let language: string | undefined = undefined;
+  export let langColor: string | undefined = undefined;
   export let stars: number;
   export let forks: number;
 </script>

diff --git a/src/util/repo.ts b/src/util/repo.ts
@@ -7,13 +7,11 @@ export interface Repo {
   name: string;
   url: string;
   isFork: boolean;
-  // TODO: Make these optional
-  // BODY: Pending https://github.com/sveltejs/language-tools/issues/805
-  description: string | undefined;
-  sourceUrl: string | undefined;
-  sourceName: string | undefined;
-  language: string | undefined;
-  langColor: string | undefined;
+  description?: string;
+  sourceUrl?: string;
+  sourceName?: string;
+  language?: string;
+  langColor?: string;
   stars: number;
   forks: number;
 }