fix(image loader): clear src and srct on changes and pre load image

prevents rendered image being reused when inputs change
thisissoon · May 21, 2018 · 9682008 · 9682008
1 parent bc4bacf
commit 9682008
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/src/app/image-loader/image-loader/image-loader.component.spec.ts b/src/app/image-loader/image-loader/image-loader.component.spec.ts
@@ -218,4 +218,10 @@ describe('ImageLoaderComponent', () => {
     component.ngOnChanges();
     expect(spy).toHaveBeenCalled();
   });
+
+  it('should preload image on changes', () => {
+    const spy = spyOn(component, 'preloadImage');
+    component.ngOnChanges();
+    expect(spy).toHaveBeenCalled();
+  });
 });
diff --git a/src/app/image-loader/image-loader/image-loader.component.ts b/src/app/image-loader/image-loader/image-loader.component.ts
@@ -340,6 +340,9 @@ export class ImageLoaderComponent implements OnInit, AfterViewInit, OnDestroy, O
    * @memberof ImageLoaderComponent
    */
   public ngOnChanges(): void {
+    this.src = '';
+    this.srcset = '';
     this.setPlaceholder();
+    this.preloadImage();
   }
 }