Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

100ms hand detection #7

Merged
merged 4 commits into from
Jul 5, 2023

Conversation

hdJerry
Copy link
Contributor

@hdJerry hdJerry commented Jul 4, 2023

After all the changes to 100ms have been implemented and merged, we want to apply the ML on that branch.

AC:

  • Create a new branch called "100ms-hand-detection".
  • Apply the ML that is currently on the other ML branh in main
  • Ensure all works as expected

NOTE: we just want the hand detection and the Letter detection, we do not want the Flexible layout and the zoom while talking feature

@hdJerry hdJerry requested a review from Zelig880 July 4, 2023 19:05
@hdJerry hdJerry self-assigned this Jul 4, 2023
@hdJerry hdJerry linked an issue Jul 4, 2023 that may be closed by this pull request
3 tasks
Copy link
Contributor

@Zelig880 Zelig880 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a super small comment..

Also we are not merging this into MAIN but leaving it as a new branch.. so I am going to change the merging destination

);

if (
estimatedGestures.gestures[maxConfidence].name !== "thumbs_up"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why don't we actually remove the "thumbs_up" from the code above, so that thumbsup is not in the estimations at all! :)

Removing the "thumbs_up_ from the estimation, will remove the need to have this if statement

image

@Zelig880 Zelig880 changed the base branch from main to 100ms-tensorflow-handsign-detection July 5, 2023 07:22
@Zelig880
Copy link
Contributor

Zelig880 commented Jul 5, 2023

@hdJerry we also need to update the README to provide information on what this branch has to offer!

intro to Tensorflow, Fingerpose and the just an intro of the file used..

You can even get this from your blog (just a small part of it)

@hdJerry hdJerry requested a review from Zelig880 July 5, 2023 10:43
@Zelig880 Zelig880 merged commit 98a367c into 100ms-tensorflow-handsign-detection Jul 5, 2023
@Zelig880 Zelig880 deleted the 100ms-hand-detection branch July 5, 2023 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ML on 100ms example
2 participants